Skip to content

settings: fix background color #87654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JonasBa merged 2 commits into from
Mar 24, 2025
Merged

settings: fix background color #87654

JonasBa merged 2 commits into from
Mar 24, 2025

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Mar 21, 2025

Not sure what this is supposed to be, but it's not an alert, and it def doesn't pass accessibility.

CleanShot 2025-03-21 at 18 22 34@2x

After:
CleanShot 2025-03-21 at 18 22 12@2x

@JonasBa JonasBa requested a review from a team March 21, 2025 22:22
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 21, 2025
evanpurkhiser
evanpurkhiser reviewed Mar 21, 2025
View reviewed changes
static/app/views/settings/components/dataScrubbing/organizationRules.tsx

const Wrapper = styled('div')<{contentHeight?: string; isCollapsed?: boolean}>`
color: ${p => p.theme.gray200};
color: ${p => p.theme.subText};
Copy link
Member

@evanpurkhiser evanpurkhiser Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrealted subtext fix right

@codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
9984 1 9983 12
View the top 1 failed test(s) by shortest run time 
WidgetBuilder Events Widgets Custom Performance Metrics displays custom performance metric in column select dropdown
Stack Traces | 1.82s run time 
Error: Unable to find an element with the text: measurements.custom.measurement. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../dashboards/widgetBuilder/widgetBuilderDataset.spec.tsx:1111:50)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@JonasBa JonasBa merged commit 488bcaf into master Mar 24, 2025
40 checks passed
@JonasBa JonasBa deleted the jb/settings/privacy branch March 24, 2025 12:31
andrewshie-sentry pushed a commit that referenced this pull request Mar 27, 2025
@JonasBa @andrewshie-sentry
settings: fix background color (#87654)
f2d88e0 
Not sure what this is supposed to be, but it's not an alert, and it def
doesn't pass accessibility.

![CleanShot 2025-03-21 at 18 22
34@2x](https://github.com/user-attachments/assets/81402718-add7-481f-9cf2-293699ef3eb7)

After:
![CleanShot 2025-03-21 at 18 22
12@2x](https://github.com/user-attachments/assets/66606d28-3261-43c1-bc6f-2531319c98e2)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JonasBa @evanpurkhiser