Skip to content

Conversation

@malwilley
Copy link
Member

  • Adds tour_key to each event so we can differentiate between tours (like issue details and the nav)
  • Adds step_count because why not, might be useful
  • Adds an event when the user clicked "finish tour", figured that might also be useful

@malwilley malwilley requested review from a team and leeandher March 21, 2025 23:16
@malwilley malwilley changed the title feat(tour): Track more in the tour analytics feat(tour): Track more tour analytics Mar 21, 2025
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 21, 2025
offset,
});

useEffect(() => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These events are now being collected in the parent TourElement component since that has access to the tour_key

Copy link
Member

@leeandher leeandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@malwilley malwilley merged commit 32ba37e into master Mar 24, 2025
42 checks passed
@malwilley malwilley deleted the malwilley/feat/tour-more-analytics branch March 24, 2025 16:39
@sentry
Copy link

sentry bot commented Mar 25, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: i.value.errors is undefined /:orgId/:projectId/events/:eventId/ View Issue

Did you find this useful? React with a 👍 or 👎

andrewshie-sentry pushed a commit that referenced this pull request Mar 27, 2025
- Adds `tour_key` to each event so we can differentiate between tours
(like issue details and the nav)
- Adds `step_count` because why not, might be useful
- Adds an event when the user clicked "finish tour", figured that might
also be useful
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants