feat(tour): Allow some elements to not render a tooltip at all #87671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
changed the title
roggenkemper
approved these changes
Mar 21, 2025
leeandher
approved these changes
Mar 24, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
For the navigation tour, we want to both the selected primary item and the elements in the secondary sidebar, so multiple tour elements needs to be used. This PR prevents the tooltip from being rendered if nothing is passed for the title or description. That allows us to highlight multiple elements where only one displays a tooltip.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the navigation tour, we want to both the selected primary item and the elements in the secondary sidebar, so multiple tour elements needs to be used.
This PR prevents the tooltip from being rendered if nothing is passed for the title or description. That allows us to highlight multiple elements where only one displays a tooltip.