Skip to content

Conversation

@malwilley
Copy link
Member

Depends on #88041

Adds the 'All Views' page when you have the issue-view-sharing feature flag enabled.

Note that:

  • Search input is there, but does not do anything yet
  • Sorting isn't implemented yet
  • This is using the default table styles and loading states for now, but we can make those look better in the future

CleanShot 2025-03-26 at 15 46 58

@malwilley malwilley requested a review from MichaelSun48 March 26, 2025 22:50
@malwilley malwilley requested a review from a team as a code owner March 26, 2025 22:50
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 26, 2025
@codecov
Copy link

codecov bot commented Mar 26, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
10039 2 10037 5
View the top 2 failed test(s) by shortest run time
provisionSubscriptionAction removes retain on-demand budget toggle when plan changes
Stack Traces | 1.08s run time
Error: Unable to find an element with the text: Invoiced. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.select (.../js/sentry-test/selectEvent.tsx:103:80)
    at Object.<anonymous> (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:639:5)
provisionSubscriptionAction retains on-demand budget when toggled
Stack Traces | 10.1s run time
Error: thrown: "Exceeded timeout of 10000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at .../gsAdmin/components/provisionSubscriptionAction.spec.tsx:490:3
    at _dispatchDescribe (.../jest-circus/build/index.js:91:26)
    at describe (.../jest-circus/build/index.js:55:5)
    at Object.<anonymous> (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:14:1)
    at Runtime._execModule (.../jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../jest-runtime/build/index.js:882:12)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

@MichaelSun48 MichaelSun48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Tiny bug I noticed is that the cache for visibility='owner' isn't updated when you click on New View, so you won't see it in the All View page until a page refresh. But I think that makes sense since we'll be changing how add view works pretty soon.

Comment on lines +180 to +184
${p =>
p.isFirst &&
css`
border-top: 1px solid ${p.theme.border};
`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would :first-child work here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not because the header will be the first child :/

Don't think there's a good way to do this in CSS

@malwilley malwilley merged commit 70762b7 into master Mar 27, 2025
40 checks passed
@malwilley malwilley deleted the malwilley/feat/issue-views-list branch March 27, 2025 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants