Skip to content

ref(js): Remove browserHistory from ClientSecretModal #88767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

ref(js): Remove browserHistory from ClientSecretModal #88767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions static/gsAdmin/views/instanceLevelOAuth/components/clientSecretModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import {Fragment} from 'react';

import type {ModalRenderProps} from 'sentry/actionCreators/modal';
import {Button} from 'sentry/components/core/button';
import {browserHistory} from 'sentry/utils/browserHistory';
import {LinkButton} from 'sentry/components/core/button';

interface ClientDetails {
clientID: string;
Expand All @@ -23,12 +22,9 @@ function ClientSecretModal({
Your client secret is <b>{clientSecret}</b>
</p>
<p>Make sure you save this now! You will not be able to see it again later.</p>
<Button
priority="danger"
onClick={() => browserHistory.push(`/_admin/instance-level-oauth/${clientID}/`)}
>
<LinkButton priority="danger" to={`/_admin/instance-level-oauth/${clientID}/`}>
I understand, take me to the rest of my client details.
</Button>
</LinkButton>
</Body>
</Fragment>
);
Expand Down
Loading