feat(issue-views): Add save functionality#88985
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
MichaelSun48
approved these changes
Apr 8, 2025
Comment on lines
+43
to
+63
| setApiQueryData<GroupSearchView>( | ||
| queryClient, | ||
| makeFetchGroupSearchViewKey({orgSlug: organization.slug, id: parameters.id}), | ||
| data | ||
| ); | ||
|
|
||
| // Update any matching starred views in cache | ||
| setApiQueryData<GroupSearchView[]>( | ||
| queryClient, | ||
| makeFetchGroupSearchViewsKey({orgSlug: organization.slug}), | ||
| oldGroupSearchViews => { | ||
| return ( | ||
| oldGroupSearchViews?.map(view => { | ||
| if (view.id === parameters.id) { | ||
| return {...view, ...parameters}; | ||
| } | ||
| return view; | ||
| }) ?? [] | ||
| ); | ||
| } | ||
| ); |
Contributor
There was a problem hiding this comment.
Is it common to maintain two separate query caches for a multi-resource and single-resource endpoints? Is it possible to combine these two?
Member
Author
There was a problem hiding this comment.
Yeah it's quite common! React query conceptually has a cache for each endpoint, so there isn't a way to really combine them except by adding some sort of abstraction
malwilley
force-pushed
the
malwilley/feat/issue-view-save-data
branch
from
95fe8ae to
d16d0dc
Compare
malwilley
changed the title
Christinarlong
pushed a commit
that referenced
this pull request
Apr 10, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #88974
Adds save functionality to the save button.