ref(shared-views): Rewire reordering event handler to use new endpoint#89108
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
scttcper
reviewed
Apr 8, 2025
Comment on lines
+21
to
+26
| export const useUpdateGroupSearchViewStarredOrder = ( | ||
| options: Omit< | ||
| UseMutationOptions<void, RequestError, UpdateGroupSearchViewStarredOrderVariables>, | ||
| 'mutationFn' | ||
| > = {} | ||
| ) => { |
Member
There was a problem hiding this comment.
would leave out options until you need them
scttcper
approved these changes
Apr 8, 2025
malwilley
approved these changes
Apr 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89108 +/- ##
==========================================
- Coverage 87.69% 82.91% -4.79%
==========================================
Files 10094 10094
Lines 571188 571187 -1
Branches 22446 22446
==========================================
- Hits 500929 473621 -27308
- Misses 69851 97158 +27307
Partials 408 408 |
Christinarlong
pushed a commit
that referenced
this pull request
Apr 10, 2025
#89108) Creates the frontend hook that calls the new `PUT` `/group-search-views/starred/order/` endpoint to reorder views, rather than using the now deprecated `PUT` `/group-search-views/` endpoint, like before. Rewires the onReorderComplete hook to call the new endpoint instead.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
#89108) Creates the frontend hook that calls the new `PUT` `/group-search-views/starred/order/` endpoint to reorder views, rather than using the now deprecated `PUT` `/group-search-views/` endpoint, like before. Rewires the onReorderComplete hook to call the new endpoint instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates the frontend hook that calls the new
PUT/group-search-views/starred/order/endpoint to reorder views, rather than using the now deprecatedPUT/group-search-views/endpoint, like before.Rewires the onReorderComplete hook to call the new endpoint instead.