Use new navigation in admin view #90426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
Apr 25, 2025
| <SecondaryNav.Header> | ||
| {PRIMARY_NAV_GROUP_CONFIG[PrimaryNavGroup.SETTINGS].label} | ||
| </SecondaryNav.Header> | ||
| <SecondaryNav.Header /> |
Member
Author
There was a problem hiding this comment.
Changed the behavior so that the header will by default use the default group label - otherwise the label would always have been settings
malwilley
commented
Apr 25, 2025
| import {AdminNavigation} from 'sentry/views/admin/adminLayout'; | ||
|
|
||
| export function AdminSecondaryNav() { | ||
| return <AdminNavigation />; |
Member
Author
There was a problem hiding this comment.
Not doing much right now, but will copy this component over when GA'd
malwilley
commented
Apr 25, 2025
| <Tooltip title={label} disabled={showLabel} position="right" skipWrapper delay={0}> | ||
| <Tooltip | ||
| title={label} | ||
| disabled={showLabel || disableTooltip} |
Member
Author
There was a problem hiding this comment.
While I was modifying the user dropdown, disabled the tooltip since it is unnecessary
MichaelSun48
approved these changes
Apr 25, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar changes that were done in settings to get the nav items to render in the secondary navigation rather than in the page. This is for the
sentry.io/managepage which is used for self hosted customers.