ref(tsc): convert projectGeneralSettings to FC #90458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
michellewzhang
force-pushed
the
mz/proj-general-settings
branch
from
314ce13 to
2db85e6
Compare
static/app/views/settings/projectGeneralSettings/index.spec.tsx
Outdated
Show resolved
Hide resolved
michellewzhang
requested review from
a team,
malwilley,
priscilawebdev and
scttcper
malwilley
reviewed
Apr 28, 2025
| ); | ||
| }; | ||
|
|
||
| const unsubscribe = ProjectsStore.listen(onProjectsUpdate, undefined); |
Member
There was a problem hiding this comment.
Can you use useLegacyStore() instead here?
| recreateRoute('', { | ||
| ...this.props, | ||
| params: { | ||
| ...this.props.params, |
Member
There was a problem hiding this comment.
Looks like we lost the additional props and params - are those necessary? There might be an orgId if there is no customer domain, and this.props used to include location and routes
Contributor
Author
There was a problem hiding this comment.
i added back orgId into the params and also location
malwilley
approved these changes
Apr 28, 2025
priscilawebdev
approved these changes
Apr 29, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://github.com/getsentry/frontend-tsc/issues/2