feat(issue-taxonomy): Recategorize warning issue categories#90824
Merged
malwilley merged 3 commits intoMay 5, 2025
Conversation
github-actions
Bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90824 +/- ##
===========================================
+ Coverage 46.22% 87.80% +41.57%
===========================================
Files 10281 10287 +6
Lines 583359 583793 +434
Branches 22585 22514 -71
===========================================
+ Hits 269660 512571 +242911
+ Misses 313275 70808 -242467
+ Partials 424 414 -10 |
MichaelSun48
reviewed
May 5, 2025
| description = "Function Regression" | ||
| category = GroupCategory.PERFORMANCE.value | ||
| category_v2 = GroupCategory.PERFORMANCE_BEST_PRACTICE.value | ||
| category_v2 = GroupCategory.PERFORMANCE_REGRESSION.value |
Contributor
There was a problem hiding this comment.
Guessing PERFORMANCE_REGRESSION = METRIC?
Member
Author
There was a problem hiding this comment.
Yeah it is now - renaming to METRIC
MichaelSun48
approved these changes
May 5, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
- PERFORMANCE_BEST_PRACTICE types gets broken out into DB_QUERY, HTTP_CLIENT, and FRONTEND - RESPONSIVENESS is now MOBILE or FRONTEND - USER_EXPERIENCE types go into FRONTEND - PERFORMANCE_REGRESSIONS becomes METRIC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes to the new category structure after receiving feedback, following the changes in this spreadsheet: