feat(uptime): Rework try_check_and_update_regions to move probabalistic check up a level. #91395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
…stic check up a level. We have a runbook script that we want to be able to use to force all regions to recheck and update. We don't need these probabalistic checks there, or anywhere else, so just moving them up to where we call the function instead.
wedamija
force-pushed
the
danf/uptime-force-region-update
branch
from
58555df to
87a2b64
Compare
wedamija
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #91395 +/- ##
=======================================
Coverage 87.64% 87.64%
=======================================
Files 10314 10314
Lines 586080 586067 -13
Branches 22602 22602
=======================================
- Hits 513644 513635 -9
+ Misses 72008 72004 -4
Partials 428 428 |
evanpurkhiser
approved these changes
May 12, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
We have a runbook script that we want to be able to use to force all regions to recheck and update. Adding this parameter to support that. <!-- Describe your PR here. -->
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a runbook script that we want to be able to use to force all regions to recheck and update. We don't need these probabalistic checks there, or anywhere else, so just moving them up to where we call the function instead.