fix(quick-start): Adjust checkmarks size #92716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
constantinius
approved these changes
Jun 3, 2025
shellmayr
approved these changes
Jun 3, 2025
malwilley
approved these changes
Jun 3, 2025
priscilawebdev
deleted the
priscila/fix/quick-start/completed-icon-does-not-look-good
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 4, 2025
This PR adds the necessary IconDefaultsProvider context without applying legacyIconSize, preventing the check mark in the quick start from looking weird closes TET-531
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that legacySize was intentionally set for the main sidebar icon (see), but this is unintentionally affecting the checkmark in the Quick Start item.
This PR adds the necessary IconDefaultsProvider context without applying legacyIconSize, preventing the interference.
Before
After
closes https://linear.app/getsentry/issue/TET-531/quickstart-completed-icon-does-not-look-good