-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
js: yarn v1 to pnpm (rollout stage 2 of 3, prod builds with pnpm) #92791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 57779bb.
(cherry picked from commit d8f1425)
scttcper
approved these changes
Jun 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92791 +/- ##
==========================================
+ Coverage 87.90% 87.92% +0.01%
==========================================
Files 10267 10266 -1
Lines 589971 589611 -360
Branches 22923 22841 -82
==========================================
- Hits 518629 518425 -204
+ Misses 70897 70740 -157
- Partials 445 446 +1 |
evanpurkhiser
approved these changes
Jun 4, 2025
Member
Author
|
i'm going to force merge and fix-forward enforce-license-compliance. it actually passed here: https://github.com/getsentry/sentry/actions/runs/15449512367 just did not generate a report because edit: ok this is just a onetime thing / edge case, see actions/dependency-review-action#786 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stage 1: #91304
this is part 2 of a 3 stage rollout (we need to keep yarn around for prod cloudbuld which hits src/sentry/build/_static_assets.py):