Skip to content

Conversation

@joshuarli
Copy link
Member

stage 1: #91304

this is part 2 of a 3 stage rollout (we need to keep yarn around for prod cloudbuld which hits src/sentry/build/_static_assets.py):

  1. (sentry) install pnpm, use it in dev+ci, keep prod build parts using yarn
  2. (getsentry) same
  3. (sentry) move prod build parts to pnpm
  4. (getsentry) no action required since js-builder will have pnpm already
  5. (sentry) delete yarn
  6. (getsentry) same

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 3, 2025
@joshuarli joshuarli changed the title js: yarn v1 to pnpm (rollout stage 2 of 3) js: yarn v1 to pnpm (rollout stage 2 of 3, prod builds with pnpm) Jun 3, 2025
@joshuarli joshuarli marked this pull request as ready for review June 3, 2025 23:01
@joshuarli joshuarli requested a review from scttcper June 3, 2025 23:01
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92791      +/-   ##
==========================================
+ Coverage   87.90%   87.92%   +0.01%     
==========================================
  Files       10267    10266       -1     
  Lines      589971   589611     -360     
  Branches    22923    22841      -82     
==========================================
- Hits       518629   518425     -204     
+ Misses      70897    70740     -157     
- Partials      445      446       +1     

Base automatically changed from yarn-to-pnpm to master June 4, 2025 18:31
@joshuarli joshuarli requested review from a team as code owners June 4, 2025 18:31
@joshuarli
Copy link
Member Author

joshuarli commented Jun 4, 2025

i'm going to force merge and fix-forward enforce-license-compliance.

it actually passed here: https://github.com/getsentry/sentry/actions/runs/15449512367

just did not generate a report because

 dependency-review
$GITHUB_STEP_SUMMARY upload aborted, supports content up to a size of 1024k, got 3321k. For more information see: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-markdown-summary

edit: ok this is just a onetime thing / edge case, see actions/dependency-review-action#786

@joshuarli joshuarli merged commit 7dd68ab into master Jun 4, 2025
56 of 57 checks passed
@joshuarli joshuarli deleted the yarn-to-pnpm-stage2 branch June 4, 2025 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants