-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix(uptime): Make body null when form method is get, head, or options #93001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for this, going to iterate on this! |
|
Hmmm, we should already be hiding the body using this sentry/static/app/views/alerts/rules/uptime/uptimeAlertForm.tsx Lines 259 to 261 in 9daaa55
|
- When chaining methods from POST -> GET (or similar), do not display the body in the preview HTTP request. - Clear the body when saving and a body was previously set. - Include `OPTIONS` in disallowed body methods Fixes: [RTC-1004: Uptime Monitoring - GET req includes body](https://linear.app/getsentry/issue/RTC-1004/uptime-monitoring-get-req-includes-body) Fixes: #84934 Replaces: #93001
|
Closing out in favor of #93111 |
|
Thanks for the review! Correct, the body was already hidden, was trying to avoid setting in two places. But looking at your fix, it was probably unneeded. |
- When chaining methods from POST -> GET (or similar), do not display the body in the preview HTTP request. - Clear the body when saving and a body was previously set. - Include `OPTIONS` in disallowed body methods Fixes: [RTC-1004: Uptime Monitoring - GET req includes body](https://linear.app/getsentry/issue/RTC-1004/uptime-monitoring-get-req-includes-body) Fixes: #84934 Replaces: #93001
- When chaining methods from POST -> GET (or similar), do not display the body in the preview HTTP request. - Clear the body when saving and a body was previously set. - Include `OPTIONS` in disallowed body methods Fixes: [RTC-1004: Uptime Monitoring - GET req includes body](https://linear.app/getsentry/issue/RTC-1004/uptime-monitoring-get-req-includes-body) Fixes: #84934 Replaces: #93001 Requires: #93110
- When chaining methods from POST -> GET (or similar), do not display the body in the preview HTTP request. - Clear the body when saving and a body was previously set. - Include `OPTIONS` in disallowed body methods Fixes: [RTC-1004: Uptime Monitoring - GET req includes body](https://linear.app/getsentry/issue/RTC-1004/uptime-monitoring-get-req-includes-body) Fixes: #84934 Replaces: #93001 Requires: #93110
A fix for #84934. Body can be string or null, this makes body null when form method is get, head, or options.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.