Skip to content

Conversation

@brendanhsentry
Copy link
Member

Adds Prevent data categories from getsentry/relay#5052

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 13, 2025
@brendanhsentry brendanhsentry requested a review from a team August 13, 2025 22:39
@brendanhsentry brendanhsentry marked this pull request as ready for review August 13, 2025 22:39
@brendanhsentry brendanhsentry requested a review from a team as a code owner August 13, 2025 22:39
@brendanhsentry
Copy link
Member Author

@joshuarli is this the right way to update versions with uv? Lmk if I'm missing something

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@joshuarli joshuarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hmm instead of uv lock it needs to be uv lock --upgrade-package sentry-relay to actually update, i've done this for you but need to look into this

@joshuarli
Copy link
Member

Oh hmm instead of uv lock it needs to be uv lock --upgrade-package sentry-relay to actually update, i've done this for you but need to look into this

@asottile-sentry uv lock surprisingly doesn't do anything after sentry-relay>=0.9.11 -> sentry-relay>=0.9.12 (bug? clearly the lockfile isn't satisfying constraints in pyproject.toml anymore), it needs to be explicitly told to upgrade that one package: uv lock --upgrade-package sentry-relay. Interestingly enough, uv lock --upgrade-package foobar also... works but also feels like a bug I might report. Should we.... switch back to == for top level? sentry-relay==0.9.11 -> sentry-relay==0.9.12 then uv lock works as expected.

Related discussion: astral-sh/uv#6692 (comment)

@asottile-sentry
Copy link
Contributor

god uv sucks. why would it work like that

we should not use ==

@joshuarli joshuarli merged commit bb27442 into master Aug 14, 2025
63 checks passed
@joshuarli joshuarli deleted the brendan/bump-sentry-relay branch August 14, 2025 18:04
@joshuarli
Copy link
Member

Huh wtf I can't reproduce anymore, uv lock works now

priscilawebdev pushed a commit that referenced this pull request Aug 25, 2025
andrewshie-sentry pushed a commit that referenced this pull request Aug 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants