refactor(agents): remove per-agent muster token machinery, forward-token only#198
Merged
Conversation
…ken only With M2M removed, the static SA-token path (muster-token-init Job, muster-refresh CronJob, token pod-spec helper, Secret-writer RBAC, and the headersFrom Authorization on the per-agent muster RemoteMCPServer) served no remaining mode. The RemoteMCPServer now carries no static credentials: the propagated muster on-behalf-of token is the only Authorization. The agents.definitions.<agent>.obo flag and the agents.muster image/TTL/schedule values are removed with it. docs/authentication.md describes the forward-token model (one muster-issued token, validated and forwarded byte-identical).
fiunchinho
approved these changes
Jul 6, 2026
muster#968 (v1.0.0) removed JWT mode and the self-issued exchange: muster never signs tokens and no backend trusts a muster issuer. Update the OBO and edge-validation docs and template comments to the forward/exchange-at-Dex model, and remove the superseded obo.enabled Changed entry (this PR removes that flag).
# Conflicts: # helm/agentic-platform-connectivity/templates/kagent/agents/remotemcpservers.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session 4 of the OBO single-token refactor, updated for the dex-only ruling on giantswarm/muster#947 (implemented by giantswarm/muster#968, released as muster v1.0.0): Dex is the sole SSO authority, muster never signs tokens, and no backend trusts a muster issuer.
With M2M gone (#197), the per-agent static SA-token path has no remaining consumer. Agents reach muster only on behalf of a user: kagent propagates the human's Dex-issued token (
KAGENT_PROPAGATE_TOKEN) as the soleAuthorizationto muster; muster validates it and, per the downstream server'sauth.mode, either forwards it unchanged (forward) or exchanges it at the spoke's Dex (exchange). muster issues no token of its own, so the agent's identity is not asserted downstream; the forwarded token carries the human.Removed from
agentic-platform-connectivity(and the umbrella defaults):muster-token-initJob,muster-refreshCronJob, the shared token pod-spec helper, and the Secret-writer Role/RoleBindingheadersFromAuthorizationon the per-agent musterRemoteMCPServeragents.definitions.<agent>.oboflag (acting on behalf of the user is the only mode; nothing left to toggle)agents.muster.{kubectlImage,busyboxImage,tokenExpirationSeconds,tokenRefreshSchedule}agents.remoteMcpServers[].tokenSecretnow only accepts a pre-existing Secret. The chart-owned agent ServiceAccount stays as the agent pod's runtime identity.docs/authentication.mdis rewritten for the dex-only model:forwardcarries the Dex token unchanged,exchangeruns RFC 8693 at the spoke's Dex, and edge validation (oauthMode: validate) verifies against Dex's JWKS, never muster's. The muster-signs-JWTs /enableJWTMode/localMintcontent is gone, matching what muster#968 removed.Part of the forward-token series; merges after the upstream stack.