Use getattr instead of eval

[Piphi5]

getattr is more robust and cleaner than trying to use eval for getting parameters

[giswqs]

It seems get_attr does not exist. Should it be getattr?

[Piphi5]

Yeah it is, my bad.

[giswqs]

It is still failing. I am not sure if they are caused by the tests only or getattr changes result in failed tests. Can you fix it?

[Piphi5]

Yeah I'll look into it. It seems like trying to call "OpenStreetMap.Mapnik" as a single parameter may be the main issue

[lgtm-com]

This pull request fixes 3 alerts when merging 98d74ee into c28a48a - view on LGTM.com

fixed alerts:

• 3 for Suspicious unused loop iteration variable

[giswqs]

It is improving. Only test_add_circle_markers_from_xy is failing.

[Piphi5]

Is there any reason why this:

out_str = m.to_html()
assert "World Cities" in out_str

would fail with add_circle_markers_from_xy but not fail with add_xy_data?

[lgtm-com]

This pull request fixes 3 alerts when merging 1b051a8 into d5d4248 - view on LGTM.com

fixed alerts:

• 3 for Suspicious unused loop iteration variable

[giswqs]

It should be name rather than layer_name. It seems add_circle_markers_from_xy is not producing the expected results. There is only one circle plotted on the map. It seems there is a bug with this function, but it might not be related to your commits.

import leafmap
import ipyleaflet

m = leafmap.Map()
in_csv = "https://raw.githubusercontent.com/giswqs/data/main/world/world_cities.csv"

m.add_circle_markers_from_xy(
    in_csv, x="longitude", y="latitude", name="World Cities"
)
m.add_control(ipyleaflet.LayersControl(position="topright"))
m

[Piphi5]

is the add_circle bug reproducable without the code in this pr?

[giswqs]

It is a bug of the ipyleaflet backend. Works fine with folium.

[lgtm-com]

This pull request fixes 3 alerts when merging 05b6daa into d5d4248 - view on LGTM.com

fixed alerts:

• 3 for Suspicious unused loop iteration variable