update-download-data: accommodate for Git for Windows' four-part version format #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion format Git for Windows' versions are usually based on upstream Git versions, and hence uses the same version string. Every once in a while, an extra version is required, in which case Git for Windows appends an extra number in parentheses, starting with 2 (implying that regular Git for Windows versions are implicitly "(1)"), at least where parentheses can be used (otherwise it appends it separated by a dot). Accommodate for such versions in the script that wants to update the download data. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Updated via the `update-download-data.yml` GitHub workflow.
Member
Author
|
For the record, the second commit was added via this GitHub workflow that I triggered manually to demonstrate that this fix works. That same run deployed the site to https://dscho.github.io/git-scm.com/downloads/win, where the fix can be verified manually. |
Member
Author
|
@rimrul would you mind reviewing this? |
Liabaemt
reviewed
Oct 31, 2024
| filename: Git-2.47.0-32-bit.exe | ||
| release_date: '2024-10-08' | ||
| version: 2.47.0 | ||
| url: https://github.com/git-for-windows/git/releases/download/v2.47.0.windows.1/Git-2.47.0-32-bit.exe |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Accommodate for Git for Windows' "intermediate" versions in the script that wants to update the download data.
Context
Git for Windows' versions are usually based on upstream Git versions, and hence uses the same version string.
Every once in a while, an extra, intermediate version is required, in which case Git for Windows appends an extra number in parentheses, starting with 2 (implying that regular Git for Windows versions are implicitly "(1)"), at least where parentheses can be used (otherwise it appends it separated by a dot).
It was noticed that the current v2.47.0(2) was not picked up by git-scm.com, and that users kept downloading v2.47.0.