Skip to content

update-download-data: accommodate for Git for Windows' four-part version format #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2024
Merged

update-download-data: accommodate for Git for Windows' four-part version format #1911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9969712
update-download-data: accommodate for Git for Windows' four-part vers…
dscho Oct 26, 2024
c328fb1
Update download data (Git for Windows v2.47.0.2)
Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions hugo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,22 @@ params:
filename: git-2.33.0-intel-universal-mavericks.dmg
windows_installer:
portable32:
filename: PortableGit-2.47.0-32-bit.7z.exe
release_date: '2024-10-08'
version: 2.47.0
url: https://github.com/git-for-windows/git/releases/download/v2.47.0.windows.1/PortableGit-2.47.0-32-bit.7z.exe
filename: PortableGit-2.47.0.2-32-bit.7z.exe
release_date: '2024-10-22'
version: 2.47.0(2)
url: https://github.com/git-for-windows/git/releases/download/v2.47.0.windows.2/PortableGit-2.47.0.2-32-bit.7z.exe
portable64:
filename: PortableGit-2.47.0-64-bit.7z.exe
release_date: '2024-10-08'
version: 2.47.0
url: https://github.com/git-for-windows/git/releases/download/v2.47.0.windows.1/PortableGit-2.47.0-64-bit.7z.exe
filename: PortableGit-2.47.0.2-64-bit.7z.exe
release_date: '2024-10-22'
version: 2.47.0(2)
url: https://github.com/git-for-windows/git/releases/download/v2.47.0.windows.2/PortableGit-2.47.0.2-64-bit.7z.exe
installer32:
filename: Git-2.47.0-32-bit.exe
release_date: '2024-10-08'
version: 2.47.0
url: https://github.com/git-for-windows/git/releases/download/v2.47.0.windows.1/Git-2.47.0-32-bit.exe

This comment was marked as off-topic.

Sign in to view

filename: Git-2.47.0.2-32-bit.exe
release_date: '2024-10-22'
version: 2.47.0(2)
url: https://github.com/git-for-windows/git/releases/download/v2.47.0.windows.2/Git-2.47.0.2-32-bit.exe
installer64:
filename: Git-2.47.0-64-bit.exe
release_date: '2024-10-08'
version: 2.47.0
url: https://github.com/git-for-windows/git/releases/download/v2.47.0.windows.1/Git-2.47.0-64-bit.exe
filename: Git-2.47.0.2-64-bit.exe
release_date: '2024-10-22'
version: 2.47.0(2)
url: https://github.com/git-for-windows/git/releases/download/v2.47.0.windows.2/Git-2.47.0.2-64-bit.exe
8 changes: 5 additions & 3 deletions script/update-download-data.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,10 @@ def update_download_windows_versions(config)
bitness = match[3]

# Git for windows sometimes creates extra releases all based off of the same upstream Git version
# so we want to crop versions like 2.16.1.4 to just 2.16.1
# so we first want to crop versions like 2.16.1.4 to just 2.16.1
version = match[2].slice(/^\d+\.\d+\.\d+/)
# Now, as per Git for Windows' custom, append the fourth part in parens, e.g. 2.16.1(4)
version += "(#{match[2].slice(version.length + 1)})" if match[2][version.length] == "."

if version
config["windows_installer"] = {} if config["windows_installer"].nil?
Expand Down Expand Up @@ -119,8 +121,8 @@ def files_from_sourceforge(repository)
end

def version_compare(a, b)
a = a.nil? ? [] : a.gsub(/^v/, "").split(/\./)
b = b.nil? ? [] : b.gsub(/^v/, "").split(/\./)
a = a.nil? ? [] : a.gsub(/^v/, "").split(/[.()]/)
b = b.nil? ? [] : b.gsub(/^v/, "").split(/[.()]/)
while true
a0 = a.shift
b0 = b.shift
Expand Down