pitch pages #753

kziemianek · 2018-03-30T22:33:31Z

Refs: #506

Description

Add pitch pages as described #506

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows [commit guidelines]

Affected core subsystem(s)

frontend
backend

Testing

Performed manual local tests.

Refers/Fixes

Refs #506

kziemianek · 2018-03-30T22:35:03Z

app/retail/templates/idea_template.html

@@ -0,0 +1,51 @@
+<script id="idea_template" type="text/x-jsrender">


this file needs to be formated properly ...

kziemianek · 2018-03-30T22:36:15Z

app/retail/views.py

+        github_username=request.POST.get('githubUsername'),
+        summary=request.POST.get('summary'),
+        more_info=request.POST.get('moreInfo'),
+        looking_for_capital=True, #request.POST.get('lookingForCapital') returns 'fasle' or 'true'


I have no idea how to serialize properly javascript's true/false to python's True/False, any ideas?

Per this

looking_for_capital = True if request.POST.get('lookingForCapital') == 'true' else False

or

looking_for_capital = request.POST.get('lookingForCaptail') == 'true'

could be good solutions? 🤔

Yeah i saw this solution, i wonder if there is another...

I mean framework should provide proper deserializer, no manual checks spread across the code

Imma try this tomorrow: https://stackoverflow.com/questions/15476983/deserialize-a-json-string-to-an-object-in-python

Neat that looks a lot cleaner 👍🏻

codecov · 2018-03-30T22:36:54Z

Codecov Report

Merging #753 into master will increase coverage by 0.17%.
The diff coverage is 48.35%.

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   30.25%   30.43%   +0.17%     
==========================================
  Files         125      126       +1     
  Lines        9013     9102      +89     
  Branches     1157     1161       +4     
==========================================
+ Hits         2727     2770      +43     
- Misses       6178     6224      +46     
  Partials      108      108

Impacted Files	Coverage Δ
app/app/urls.py	`94.28% <ø> (ø)`	⬆️
app/retail/views.py	`34.73% <24.07%> (-4.68%)`	⬇️
app/app/settings.py	`83.33% <66.66%> (+0.18%)`	⬆️
app/retail/models.py	`85.29% <85.29%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367eb76...5ac2245. Read the comment docs.

kziemianek · 2018-03-30T22:54:23Z

Actual implementation fetches disqus thread's data on client side (most recent values, api limits may be exceeded) and there are no likes and posts counts in model so there is no way to perform sort.

To provide sorting functionality these values should be placed in model but syncing them with disqus may be problematic.

I can think of two syncing modes:

values are updated periodically(no risk to exceed api limits, values may be outdated)
values are updated during ideas list/idea fetch(api limits may be exceeded, most recent values, longer request times).

@mbeacom , @owocki does actual implementation or any of syncing modes satisfy You ?

mkosowsk · 2018-03-30T23:57:04Z

Looks great!!! :D

I defer to @owocki and @mbeacom but think option number 2 of values are updated during ideas list/idea fetch would be interesting to run with to start. Nice to have those recent values as part of feedback to the user and I don't think we'll be bumping up against API limits to start 🤔

kziemianek · 2018-03-31T09:27:50Z

I'll take a look at webhook later but seems like it's triggered only by new comments.

Unfortunately, webhooks are only available for WordPress plugin...

kziemianek · 2018-04-03T13:58:44Z

So if we want that kind of sorting we need to somehow sync our model with disqus threads data.

As @mkosowsk suggested, fetchin disquss threads data right before ideas list fetch might not have a big impact at start (disqus api max page size of 100), but as soon as we hit 200, 300, 400+ ideas on list requests times will get longer. I think we can defer this optimization.

So if we stick with this solution then when request hits ideas/fetch following actions will be taken:

disquss threads fetch
ideas fetch
ideas post_count and like_count update (if changed)
ideas fetch with sorting applied

owocki · 2018-04-03T14:25:33Z

So if we want that kind of sorting we need to somehow sync our model with disqus threads data.

hopefully there is an API and we can just refresh the model to the disquis data on the serverside and not have to do it everytime a user hits the page

kziemianek · 2018-04-03T21:52:55Z

syncing will occur every 10 minutes

owocki · 2018-04-04T20:15:21Z

very excited for this.. let me know when ready to test

kziemianek · 2018-04-04T21:27:29Z

@owocki 🏁 ready to test

kziemianek · 2018-04-04T22:27:28Z

@owocki hold on, I'll add i18n.

kziemianek · 2018-04-04T23:34:42Z

@owocki finally 🏁

kziemianek · 2018-04-05T17:47:19Z

app/retail/models.py

+    """Define the structure of idea"""
+    full_name = models.CharField(max_length=255)
+    email = models.EmailField(max_length=255)
+    github_username = models.CharField(max_length=255)


I think it might be better to reference profile here in order to remove redundancy but I see avatar_url spread across models. What do You think? Maybe refactor in another PR ?

@kziemianek Ideally, if we could reference profile and add a related name for reverse as: ideas, that would be 👍

kziemianek · 2018-04-17T13:13:46Z

No further work planned but labeled as WIP :)
If something else needs to be done in the scope of this PR hit me up!

kziemianek · 2018-05-02T21:48:09Z

@owocki @mbeacom @thelostone-mc few fixes in last commits:

It appears the username isn't rendering on the list or detail views:

fixed

Recommended doesn't display updated count on list or details view.

the command should update this value, it gets updated after a while, you want it updated right after hitting hearth ?

‘github username’ input — shouldnt this be just the ’github login

changed label to github login

when i submit and im not logged in

fixed

when i submit and i am logged in

unfortunetly I cannot reproduce this problem

javascript injection! bwahahhahaha!

cool! fixed :)

the ‘ideas/new’ and the ‘ideas show’ page need links back to the main ideas page i think

there is a link in navbar, should i add next?

URIs - why ideas/list and not ideas/ ?

changed to ideas/

URIs — why ideas/idea/2/show and not ideas/- ?

changed to ideas/ideas/... what is slug?

owocki · 2018-05-02T21:59:46Z

changed to ideas/ideas/... what is slug?

can we change to ideas/<pk>-<slug> ? i think the double ideas is wasteful in the URI

slug == the slugify method on this django util https://docs.djangoproject.com/en/2.0/ref/utils/

owocki · 2018-05-02T22:00:09Z

sweet looking fwd to testing now

kziemianek · 2018-05-02T22:25:47Z

@owocki sorry the url is ideas/idea/<int:idea_id>

kziemianek · 2018-05-02T22:29:30Z

@thelostone-mc, i made some changes according to Your comments, thanks a lot :)
here is the summary:

Nothing happens when I click on the heart icon ? (I'm logged in)

i've described it in last comment

the username doesn't turn up next to the submitted by

i've described it in last comment

Could you update the styling of the dropdown (checkout the bounty/new) The CSS is already there, you just need to update the html

You mean these dropdowns with search built-in ?

Also the page is using a mix of Futura & Muli. Could we stick to Muli ?

Changed it to Muli

Rather than defining the font-size , to ensure uniformity could we stick to using the classes defined

does this meet your expectations ?

Could we add some breathing space between disqus component and ideas (margin top/bottom of 1em ? )

definetly yes!

Is it just me / does it look odd, when the Has & Needs section are empty. Would it make sense to leave the default entry as -

added - for empty has and needs

thelostone-mc · 2018-05-03T07:51:49Z

You mean these dropdowns with search built-in ?

Yup! We'll throw in the dropdown without search later and update this then

@kziemianek looks better ^_^

kziemianek · 2018-05-03T09:08:02Z

@thelostone-mc I also updated select to use jquery select2 with hidden search box.

kziemianek · 2018-05-16T13:41:39Z

@mbeacom are we waiting for something? have you seen my last comments :) ?

mbeacom

Generally, lgtm. Deploying to staging.

mbeacom · 2018-05-17T12:56:38Z

app/retail/views.py

+        designers_exists = bool(request.POST.get('designers_exists'))
+        customer_exists = bool(request.POST.get('customer_exists'))
+        profile = request.user.profile if request.user.is_authenticated else None
+        idea = Idea(full_name=full_name, email=email, github_username=github_username, summary=summary, more_info=more_info,


v2 we should probably move this to a form.

mbeacom · 2018-05-17T13:05:20Z

Seeing the same ideas after clicking Show More

mbeacom · 2018-05-17T13:06:32Z

Also, I recommended the cooking discussion (of course! 😆) and it appears we'll need to add custom caching rules to the list page.

kziemianek · 2018-05-22T18:34:17Z

@mbeacom i bet duplicated idea was dropped to next page after another idea becoming more trending, so it was returned by paginator again.

As a workaround, I can add check to ensure only one idea with given id is displayed in list.

stickler-ci · 2018-05-22T18:39:05Z

app/assets/v2/js/pages/ideas_list.js

+
+  function loadMoreIdeas() {
+    fetchIdeas(++pageIdx, pageSize, sorting(), (result) => {
+      console.log('test');


Unexpected console statement. (no-console)

stickler-ci · 2018-05-22T18:39:05Z

app/retail/views.py

+        designers_exists = bool(request.POST.get('designers_exists'))
+        customer_exists = bool(request.POST.get('customer_exists'))
+        profile = request.user.profile if request.user.is_authenticated else None
+        idea = Idea(full_name=full_name, email=email, github_username=github_username, summary=summary, more_info=more_info,


E501 line too long (124 > 120 characters)

stickler-ci · 2018-05-31T13:59:19Z

app/retail/views.py

+from django.core.paginator import EmptyPage, PageNotAnInteger, Paginator
 from django.core.validators import validate_email
-from django.http import HttpResponse, JsonResponse
+from django.http import HttpResponse, HttpResponseRedirect, JsonResponse


F401 'django.http.HttpResponse' imported but unused

kziemianek commented Mar 30, 2018

View reviewed changes

kziemianek force-pushed the pitch branch from c29f877 to 509c3fd Compare March 31, 2018 06:42

mbeacom added feature frontend This needs frontend expertise. backend This needs backend expertise. labels Apr 2, 2018

PixelantDesign added the in progress label Apr 3, 2018

kziemianek force-pushed the pitch branch 3 times, most recently from 7bff4c2 to df128cd Compare April 3, 2018 21:51

owocki mentioned this pull request Apr 4, 2018

Pitch pages #647

Closed

kziemianek changed the title ~~WIP: pitch pages~~ pitch pages Apr 4, 2018

kziemianek force-pushed the pitch branch from 80dc908 to a56175c Compare April 4, 2018 22:37

kziemianek force-pushed the pitch branch from 2b579d2 to 381b85c Compare April 5, 2018 09:45

kziemianek commented Apr 5, 2018

View reviewed changes

PixelantDesign added needs review and removed in progress labels Apr 10, 2018

kziemianek added 5 commits May 3, 2018 00:05

changed font to Muli

a604af0

font sizes

26946ea

extra space between idea and disqus

8162a49

handle idea empty has and needs

96ef83a

lint warnings

a83a3a5

handle redirect after idea creation correctly

3324c84

updated sort_ideas to use jquery select2

0e4255c

mbeacom reviewed May 17, 2018

View reviewed changes

stickler-ci reviewed May 22, 2018

View reviewed changes

duplicated ideas workaround

dd5a2fe

kziemianek force-pushed the pitch branch from bb0aec1 to dd5a2fe Compare May 22, 2018 18:42

Merge branch 'master' into pitch

71cb245

ghost assigned mbeacom May 31, 2018

ghost added the in progress label May 31, 2018

stickler-ci reviewed May 31, 2018

View reviewed changes

Merge branch 'master' into pitch

5ac2245

kziemianek closed this Aug 17, 2018

mbeacom removed the in progress label Aug 17, 2018

kziemianek deleted the pitch branch August 17, 2018 20:45

		@@ -0,0 +1,51 @@
		<script id="idea_template" type="text/x-jsrender">

Uh oh!

pitch pages #753

pitch pages #753

Uh oh!

Conversation

kziemianek commented Mar 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Affected core subsystem(s)

Testing

Refers/Fixes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkosowsk Mar 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kziemianek commented Mar 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkosowsk commented Mar 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kziemianek commented Mar 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kziemianek commented Apr 3, 2018

Uh oh!

owocki commented Apr 3, 2018

Uh oh!

kziemianek commented Apr 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

owocki commented Apr 4, 2018

Uh oh!

kziemianek commented Apr 4, 2018

Uh oh!

kziemianek commented Apr 4, 2018

Uh oh!

kziemianek commented Apr 4, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kziemianek commented Apr 17, 2018

Uh oh!

kziemianek commented May 2, 2018

Uh oh!

owocki commented May 2, 2018

Uh oh!

owocki commented May 2, 2018

Uh oh!

kziemianek commented May 2, 2018

Uh oh!

kziemianek commented May 2, 2018

Uh oh!

thelostone-mc commented May 3, 2018

Uh oh!

kziemianek commented May 3, 2018

Uh oh!

kziemianek commented May 16, 2018

Uh oh!

mbeacom left a comment

kziemianek commented Mar 30, 2018 •

edited

Loading

mkosowsk Mar 30, 2018 •

edited

Loading

codecov bot commented Mar 30, 2018 •

edited

Loading

kziemianek commented Mar 30, 2018 •

edited

Loading

mkosowsk commented Mar 30, 2018 •

edited

Loading

kziemianek commented Mar 31, 2018 •

edited

Loading

kziemianek commented Apr 3, 2018 •

edited

Loading