fix(phase4): read root-owned OCI image store with sudo in Linux acceptance - #77
Closed
gitcommit90 wants to merge 1 commit into
Closed
fix(phase4): read root-owned OCI image store with sudo in Linux acceptance#77gitcommit90 wants to merge 1 commit into
gitcommit90 wants to merge 1 commit into
Conversation
…cceptance The retained channel-image verification checked /var/lib/1helm-oci-v1/shared-images/sha256/<digest> without sudo, but install-oci-runtime.sh creates that store root-owned and mode 0700. The ordinary runner user cannot traverse it, so the `[[ -d ... && sha256 ... ]]` assertion always failed after an otherwise successful clean install — the exact silent failure the new ERR trap pinpointed at this line. The adjacent state checks already use sudo; this one was the outlier. Run the directory test and the image digest read under sudo, matching the store's ownership. No product change; acceptance-script only. Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Linux acceptance checks now use ChangesLinux image validation
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Owner
Author
|
Folded into #78 to keep both Phase 4 conveyor fixes in one merge / one candidate run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retained channel-image check read
/var/lib/1helm-oci-v1/shared-images/sha256/<digest>(created root-owned, mode 0700 by install-oci-runtime.sh) without sudo, so it always failed after a successful clean install. Pinpointed by the ERR trap at line 75. Adjacent state checks already use sudo. Fix runs the dir test and digest read under sudo. Acceptance-script only; no product change. Both occurrences (clean-install + post-rollback) fixed. phase4 tests pass.Summary by CodeRabbit