fix(phase4): use sudo for all service-owned Linux acceptance reads - #79
Merged
Conversation
The Linux acceptance runs as the ordinary hosted runner user and elevates only for the real install. `/opt/1helm` and `/var/lib/1helm-oci-v1` are service/root owned, so direct `node require(...)` and `readlink` checks report the files as missing even after a successful install. The ERR trap pinpointed the first such failure at the previous-Stable version check. Audit and fix every service-owned read in the acceptance script at once: - read both current-version package.json files through `sudo cat` and parse their piped JSON with the ordinary runner's node; - run all three current-symlink readlink checks through sudo; - retain the already-fixed sudo reads of the root-owned OCI image store. Acceptance-script only; no product/runtime change. Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughLinux acceptance checks now use ChangesLinux acceptance checks
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acceptance runs as the ordinary hosted user, but /opt/1helm and /var/lib/1helm-oci-v1 are service/root-owned. After successful 0.0.41 and 0.0.40 installs, direct node/readlink checks reported files missing. ERR trap pinpointed line 113. Audited the entire script and fixed every service-owned read in one pass: two package.json reads via sudo cat, three current-symlink reads via sudo readlink, plus the already-fixed image-store checks. Acceptance-script only; phase4 tests pass.
Summary by CodeRabbit