Closed
Conversation
…onsToController`
keithamus
force-pushed
the
fix-listenforbind-allow-any-node-to-be-given-as-first-param
branch
from
2aed261 to
bc7b2cd
Compare
muan
reviewed
Jul 17, 2020
| if (node.hasAttribute('data-action')) { | ||
| queue.add(node) | ||
| } | ||
| queue.add(node) |
Contributor
There was a problem hiding this comment.
The subtle differences between bind and processQueue got me a bit confused so I created a test case at bc7b2cd...1f61c3d.
It looks like this line gets called when a new Catalyst element gets injected as well, so are bound repeatedly through both
connectedCallback->bind->bindActionToControllerlistenForBind-> this line ->processQueue->bindActionsToController
This was referenced Jul 20, 2020
Contributor
Author
|
Superseded by #53 |
keithamus
deleted the
fix-listenforbind-allow-any-node-to-be-given-as-first-param
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two bugs in
listenForBind:elwas inferred, so it becomesDocument | undefinedwhich is not what we want. The type should beNodeto allow us to register other, nondocumentnodes, should we need to.MutationObserveronly listened foraddedNodes, checking to see if they have thedata-actionattribute, however, if the node inserted has children we should also bind those, so a test + code has been added to do this.I've refactored the code quite extensively, the new code is much simpler - but its worth looking at each commit to see how it has changed.