Discussion: refactor use eventhandler to dispatch events#51
Closed
keithamus wants to merge 6 commits intofix-listenforbind-allow-any-node-to-be-given-as-first-paramfrom
Closed
Conversation
dgraham
reviewed
Jul 1, 2020
Contributor
Author
|
Superseded by #53 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When discussing performance concerns with
listenForBind()(a discussion motivated by #50), we looked at ways we could optimise the performance of theaddEventListenercode.One of the slowest parts of this was creating an anonymous function in a loop. A way around this is to make a centralized event handler which does the heavy lifting. We add some cheap checks inside
bindActionsToController- just enough to find out what to bind, then inhandleEventwe can do the more detailed checks. This overall looks to work out a bit better (based on my rudimentary benchmarking) for the initial bind than the closure.The nice thing about this refactoring is it also paves the way for us to listen for mutations on the
data-actionattribute; we can simply callbindActionsToControllerif the attribute changes, and it just... works itself out - it avoids double bindings, and unbinding happens automatically because the string check occurs at event dispatch instead of ahead of it.