CPP: Add more allocation functions to Alloc.qll#1158
Merged
jbj merged 4 commits intogithub:masterfrom Mar 27, 2019
Merged
Conversation
…rt the free(pointer-to-pointer) pattern in 'SysReAllocString' leading to unaccaptable FPs.
jbj
added
the
depends on internal PR
jbj
previously approved these changes
Mar 22, 2019
jbj
removed
the
depends on internal PR
Contributor
|
It looks like we can merge this before the internal PR, but I'd still like to see the test results from the internal PR before merging this. |
Contributor
|
@dave-bartolomeo please check that the new list of functions aligns with what you had in mind. |
jbj
approved these changes
Mar 27, 2019
Contributor
jbj
left a comment
jbj
left a comment
There was a problem hiding this comment.
The internal tests have passed, albeit with an outdated submodule pointer. I'll merge this now to put an end to the submodule pointer chasing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows on from #994. Add support for the functions suggested by @dave-bartolomeo, plus a couple of other variations.
@lukecartey