CPP: Add lots more allocation functions to Alloc.qll#994
Merged
dave-bartolomeo merged 2 commits intogithub:masterfrom Feb 26, 2019
Merged
CPP: Add lots more allocation functions to Alloc.qll#994dave-bartolomeo merged 2 commits intogithub:masterfrom
dave-bartolomeo merged 2 commits intogithub:masterfrom
Conversation
dave-bartolomeo
approved these changes
Feb 26, 2019
Contributor
dave-bartolomeo
left a comment
dave-bartolomeo
left a comment
There was a problem hiding this comment.
LGTM. I'm surprised that these kernel-mode allocation functions have come up, but user-mode ones like HeapAlloc(), LocalAlloc(), GlobalAlloc(), SysAllocString(), and CoTaskMemAlloc() have not.
Contributor
Author
Yes, the list was somewhat arbitrary. I'll add your suggestions (thanks!) in a future PR, though probably aimed at 1.21 rather than 1.20. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On certain Microsoft-heavy code bases, these changes may result in many new results for the 'Memory is never freed' and 'Memory may not be freed' queries.
@lukecartey