C++: Fix implicit reads on cpp/cleartext-storage-database#11768
Merged
MathiasVP merged 1 commit intogithub:mathiasvp/replace-ast-with-ir-use-usedataflowfrom Dec 22, 2022
Conversation
MathiasVP
added
no-change-note-required
MathiasVP
changed the title
cpp/cleartext-storage-databasecpp/cleartext-storage-database
Contributor
Author
|
The slowdown on DCA seems completely unrelated to this PR. It's a 15% slowdown on 1 project (which will be fixed by #11781). The stage timing report shows that all runs of |
MathiasVP
merged commit 83d751b
into
github:mathiasvp/replace-ast-with-ir-use-usedataflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there happened to be a conversion on the sink node (such as a conversion to
void*) the implicit reads added byallowImplicitReadwouldn't fire since the type of the node wouldn't be aClass(but instead, it would be whatever the result of the conversion was).This PR fixes the last FNs on the
cpp/cleartext-storage-databasequery in the internal repo.