Skip to content

C++: Fix implicit reads on cpp/cleartext-storage-database #11768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 1 commit into from
Dec 22, 2022
Merged

C++: Fix implicit reads on cpp/cleartext-storage-database #11768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions cpp/ql/src/Security/CWE/CWE-313/CleartextSqliteDatabase.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,12 @@ predicate isSourceImpl(DataFlow::Node source, SensitiveExpr sensitive) {
}

/** Holds if `sink` is an argument to an Sqlite function call `c`. */
predicate isSinkImpl(DataFlow::Node sink, SqliteFunctionCall c) {
[sink.asExpr(), sink.asIndirectExpr()] = c.getASource()
predicate isSinkImpl(DataFlow::Node sink, SqliteFunctionCall c, Type t) {
exists(Expr e |
e = c.getASource() and
e = [sink.asExpr(), sink.asIndirectExpr()] and
t = e.getUnspecifiedType()
)
}

/**
Expand All @@ -58,7 +62,7 @@ class FromSensitiveConfiguration extends TaintTracking::Configuration {
override predicate isSource(DataFlow::Node source) { isSourceImpl(source, _) }

override predicate isSink(DataFlow::Node sink) {
isSinkImpl(sink, _) and
isSinkImpl(sink, _, _) and
not sqlite_encryption_used()
}

Expand All @@ -68,15 +72,11 @@ class FromSensitiveConfiguration extends TaintTracking::Configuration {

override predicate allowImplicitRead(DataFlow::Node node, DataFlow::ContentSet content) {
// flow out from fields at the sink (only).
this.isSink(node) and
// constrain `content` to a field inside the node.
exists(Class c |
node.getType().getUnspecifiedType().stripType() = c and
content.(DataFlow::FieldContent).getField() = getRecField(c)
exists(Type t |
isSinkImpl(node, _, t) and
content.(DataFlow::FieldContent).getField() = getRecField(t.stripType())
)
or
// any default implicit reads
super.allowImplicitRead(node, content)
}
}

Expand All @@ -86,7 +86,7 @@ from
where
config.hasFlowPath(source, sink) and
isSourceImpl(source.getNode(), sensitive) and
isSinkImpl(sink.getNode(), sqliteCall)
isSinkImpl(sink.getNode(), sqliteCall, _)
select sqliteCall, source, sink,
"This SQLite call may store $@ in a non-encrypted SQLite database.", sensitive,
"sensitive information"