JavaScript: Recognise references to the process global.#1432
Merged
semmle-qlci merged 2 commits intogithub:masterfrom Jun 11, 2019
Merged
JavaScript: Recognise references to the process global.#1432semmle-qlci merged 2 commits intogithub:masterfrom
process global.#1432semmle-qlci merged 2 commits intogithub:masterfrom
Conversation
ghost
suggested changes
Jun 11, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Nice.
Can you add a test that shows that we treat process, global.process, and require('process') in the same way?
Author
|
Done. |
ghost
approved these changes
Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Node.js, the
processglobal variable contains an import of theprocessmodule from the standard library. Fortunately we can model this quite elegantly, and without hurting performance too badly (internal link).