Skip to content

JavaScript: Recognise references to the process global. #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
semmle-qlci merged 2 commits into from
Jun 11, 2019
Merged

JavaScript: Recognise references to the process global. #1432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16c33b5
JavaScript: Recognise references to the `process` global.
Jun 6, 2019
70cf32c
JavaScript: Add a few more tests.
Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,23 @@ import semmle.javascript.security.SensitiveActions

module NodeJSLib {
/**
* Gets a reference to the 'process' object.
* An access to the global `process` variable in a Node.js module, interpreted as
* an import of the `process` module.
*/
DataFlow::SourceNode process() {
result = DataFlow::globalVarRef("process") or
result = DataFlow::moduleImport("process")
private class ImplicitProcessImport extends DataFlow::ModuleImportNode::Range {
ImplicitProcessImport() {
this = DataFlow::globalVarRef("process") and
getTopLevel() instanceof NodeModule
}

override string getPath() { result = "process" }
}

/**
* Gets a reference to a member of the 'process' object.
* Gets a reference to the 'process' object.
*/
private DataFlow::SourceNode processMember(string member) {
result = process().getAPropertyRead(member) or
result = DataFlow::moduleMember("process", member)
DataFlow::SourceNode process() {
result = DataFlow::moduleImport("process")
}

/**
Expand Down Expand Up @@ -363,7 +367,7 @@ module NodeJSLib {
ProcessTermination() {
this = DataFlow::moduleImport("exit").getAnInvocation()
or
this = processMember("exit").getACall()
this = DataFlow::moduleMember("process", "exit").getACall()
}
}

Expand Down
2 changes: 2 additions & 0 deletions javascript/ql/test/library-tests/ModuleImportNodes/process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
var p1 = require('process');
var p2 = global.process;
2 changes: 2 additions & 0 deletions javascript/ql/test/library-tests/ModuleImportNodes/process2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
require('fs');
var p3 = process;
9 changes: 9 additions & 0 deletions javascript/ql/test/library-tests/ModuleImportNodes/tests.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ test_ModuleImportNode
| moduleUses.js:1:11:1:24 | require('mod') | mod | moduleUses.js:11:1:11:3 | mod | mod |
| moduleUses.js:1:11:1:24 | require('mod') | mod | moduleUses.js:13:1:13:3 | mod | mod |
| moduleUses.js:1:11:1:24 | require('mod') | mod | moduleUses.js:15:5:15:7 | mod | mod |
| process2.js:2:10:2:16 | process | process | process2.js:2:10:2:16 | process | process |
test_ModuleImportNode_getAConstructorInvocation
| destructuringES6.js:1:1:1:41 | import ... ctron'; | destructuringES6.js:2:1:2:19 | new BrowserWindow() |
| destructuringRequire.js:1:27:1:45 | require('electron') | destructuringRequire.js:2:1:2:19 | new BrowserWindow() |
Expand All @@ -22,11 +23,15 @@ test_moduleImport
| electron | destructuringRequire.js:1:27:1:45 | require('electron') |
| fs | amd1.js:1:25:1:26 | fs |
| fs | amd2.js:2:12:2:24 | require('fs') |
| fs | process2.js:1:1:1:13 | require('fs') |
| mod | moduleUses.js:1:11:1:24 | require('mod') |
| myDefaultImportedModuleInstance | instanceThroughDefaultImport.js:1:1:1:82 | import ... tance'; |
| myDefaultImportedModuleInstance | instanceThroughDefaultImport.js:1:8:1:42 | myDefaultImportedModuleInstanceName |
| myNamespaceImportedModuleInstance | instanceThroughNamespaceImport.js:1:8:1:49 | myNamespaceImportedModuleInstanceName |
| myRequiredModuleInstance | instanceThroughRequire.js:1:36:1:70 | require ... tance') |
| process | process2.js:2:10:2:16 | process |
| process | process.js:1:10:1:27 | require('process') |
| process | process.js:2:10:2:23 | global.process |
test_moduleMember
| electron | BrowserWindow | destructuringES6.js:1:10:1:22 | BrowserWindow |
| electron | BrowserWindow | destructuringRequire.js:1:9:1:21 | BrowserWindow |
Expand All @@ -47,6 +52,10 @@ test_ModuleImportNode_getPath
| instanceThroughNamespaceImport.js:1:8:1:49 | myNamespaceImportedModuleInstanceName | myNamespaceImportedModuleInstance |
| instanceThroughRequire.js:1:36:1:70 | require ... tance') | myRequiredModuleInstance |
| moduleUses.js:1:11:1:24 | require('mod') | mod |
| process2.js:1:1:1:13 | require('fs') | fs |
| process2.js:2:10:2:16 | process | process |
| process.js:1:10:1:27 | require('process') | process |
| process.js:2:10:2:23 | global.process | process |
test_ModuleImportNode_getAMethodCall
| amd1.js:1:25:1:26 | fs | amd1.js:2:3:2:29 | fs.read ... a.txt") |
| amd2.js:2:12:2:24 | require('fs') | amd2.js:3:3:3:29 | fs.read ... a.txt") |
Expand Down