Java/C++/C#: Improve performance of data flow with fields.#1799
Merged
hvitved merged 2 commits intogithub:masterfrom Aug 28, 2019
Merged
Java/C++/C#: Improve performance of data flow with fields.#1799hvitved merged 2 commits intogithub:masterfrom
hvitved merged 2 commits intogithub:masterfrom
Conversation
Contributor
|
Could we perhaps hold this back until #1761 is merged? |
Contributor
It has been merged now, so can I ask you to rebase? Then I will run a dist-compare for C# over the weekend. |
aschackmull
force-pushed
the
java/fieldflow-perf
branch
from
f4b8dbb to
2bea0a4
Compare
Contributor
Author
|
Rebased. |
Contributor
Author
|
Btw. testing locally on jdk8 with a few different configurations this has been a clear consistent improvement in wall-clock time (using 8 threads), and the number of additional visited nodes have only gone up slightly in the first two pruning steps. |
hvitved
reviewed
Aug 23, 2019
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
Changes LGTM. I would still like to run a dist-compare for C# before approving.
jbj
approved these changes
Aug 23, 2019
Contributor
|
The dist-compare report for C# shows no change in performance for our benchmark projects. Happy to merge as this simplifies the code anyway. |
hvitved
approved these changes
Aug 28, 2019
jbj
approved these changes
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first pruning step is usually the performance bottleneck, so making that as fast as possible improves overall performance even if the later steps have to inspect a few more nodes.