Skip to content

C++: Update the CWE tag of cpp/new-free-mismatch#22179

Merged
jketema merged 1 commit into
github:mainfrom
jketema:jketema.new-free
Jul 13, 2026
Merged

C++: Update the CWE tag of cpp/new-free-mismatch#22179
jketema merged 1 commit into
github:mainfrom
jketema:jketema.new-free

Conversation

@jketema

@jketema jketema commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Fixes: #22162

Copilot AI review requested due to automatic review settings July 13, 2026 11:07
@jketema jketema requested a review from a team as a code owner July 13, 2026 11:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CWE classification for cpp/new-free-mismatch to accurately reflect mismatched memory-management routines.

Changes:

  • Replaces CWE-401 with CWE-762 in query metadata.
  • Adds a change note documenting the corrected mapping.
Show a summary per file
File Description
cpp/ql/src/Critical/NewFreeMismatch.ql Updates the query’s CWE tag.
cpp/ql/src/change-notes/2026-07-13-new-free.md Documents the metadata correction.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Medium

@michaelnebel michaelnebel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jketema jketema merged commit 2656b5d into github:main Jul 13, 2026
19 checks passed
@jketema jketema deleted the jketema.new-free branch July 13, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CWE Rule Mapping: cpp/new-free-mismatch should be mapped to: CWE-762: Mismatched Memory Management Routine

3 participants