C#: Add queries to check untrusted data flow to external APIs - #4678
Merged
tamasvajk merged 4 commits intoDec 4, 2020
Conversation
Contributor
Author
hvitved
requested changes
Dec 3, 2020
hvitved
left a comment
hvitved
left a comment
Contributor
There was a problem hiding this comment.
A few minor comments, otherwise LGTM. Great to have this query in the toolbox.
hvitved
reviewed
Dec 4, 2020
| @@ -1,2 +1,3 @@ | |||
| | System.Collections.Specialized.NameValueCollection.get_Item(string) [qualifier] | 1 | 1 | | |||
Contributor
There was a problem hiding this comment.
Interesting; we should model this (like we model dictionaries). (Not on this PR.)
hvitved
previously approved these changes
Dec 4, 2020
tamasvajk
force-pushed
the
feature/external-api-untrusted-data
branch
from
December 4, 2020 12:28
1eff2a3 to
aa3ae0f
Compare
Contributor
Author
|
I rebased and pushed an extra commit to fix the CI check failure. |
hvitved
approved these changes
Dec 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of the Java matching checks.
The main differences are that
Methods butCallables,SafeExternalAPICallableadds only a super minimal safe API list for the time being.