Skip to content

Fixed matrix.dotnet-version key - #15550

Merged
lucascosti merged 2 commits into
github:mainfrom
weineran:patch-2
Feb 25, 2022
Merged

Fixed matrix.dotnet-version key#15550
lucascosti merged 2 commits into
github:mainfrom
weineran:patch-2

Conversation

@weineran

Copy link
Copy Markdown
Contributor

Changed matrix.dotnet key to matrix.dotnet-version

Why:

There was a small bug in the docs.

What's being changed:

Changed matrix.dotnet key to matrix.dotnet-version

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Changed `matrix.dotnet` key to `matrix.dotnet-version`
@welcome

welcome Bot commented Feb 16, 2022

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Feb 16, 2022
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 17, 2022
@ramyaparimi

Copy link
Copy Markdown
Contributor

@weineran
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@weineran

Copy link
Copy Markdown
Contributor Author

@weineran Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi No problem! It's a super short review, but let me know if there are any questions/comments/concerns.

@lucascosti lucascosti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix, @weineran! I'll get this merged 🚀

@lucascosti
lucascosti enabled auto-merge (squash) February 25, 2022 05:41
@lucascosti
lucascosti merged commit 96bf129 into github:main Feb 25, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants