Skip to content

Removed code backticks from <kbd> blocks#19065

Merged
sophietheking merged 3 commits intogithub:mainfrom
jnidzwetzki:wrong-style
Jul 19, 2022
Merged

Removed code backticks from <kbd> blocks#19065
sophietheking merged 3 commits intogithub:mainfrom
jnidzwetzki:wrong-style

Conversation

@jnidzwetzki
Copy link
Copy Markdown
Contributor

@jnidzwetzki jnidzwetzki commented Jul 17, 2022

Why:

Closes #19064

What's being changed (if available, include any code snippets, screenshots, or gifs):

The unnecessary code backticks around <kbd> blocks are removed.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link
Copy Markdown

welcome Bot commented Jul 17, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jul 17, 2022
@jnidzwetzki jnidzwetzki marked this pull request as ready for review July 17, 2022 18:28
@cmwilson21
Copy link
Copy Markdown
Contributor

@jnidzwetzki Thanks so much for opening a PR and linking it to your issue! ✨

I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added waiting for review Issue/PR is waiting for a writer's review content This issue or pull request belongs to the Docs Content team Codespaces Content relating to GitHub Codespaces and removed triage Do not begin working on this issue until triaged by the team labels Jul 18, 2022
@sophietheking sophietheking self-requested a review July 19, 2022 12:33
@sophietheking
Copy link
Copy Markdown
Contributor

Hi @jnidzwetzki 👋 thanks for spotting this and fixing it, we really appreciate it. ✨ I'll get this merged for you! 🚀

@sophietheking sophietheking enabled auto-merge July 19, 2022 12:37
@sophietheking sophietheking merged commit c82ca6e into github:main Jul 19, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary code backticks around <kbd> blocks

3 participants