Skip to content

Update working-with-ssh-key-passphrases.md #22822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
victoremeka wants to merge 1 commit into from
Closed

Update working-with-ssh-key-passphrases.md #22822

victoremeka wants to merge 1 commit into from

Conversation

@victoremeka
Copy link

@victoremeka victoremeka commented Dec 22, 2022

Added clearer directions to locating ~/.profile or ~/.bashrc file for windows users.

Why:

Closes ISSUE

What's being changed:

Line 43 in the content/authentication/connecting-to-github-with-ssh/working-with-ssh-key-passphrases.md file.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@victoremeka
Update working-with-ssh-key-passphrases.md
45638dd 
Added clearer directions to locating `~/.profile` or `~/.bashrc` file for windows users.
@welcome
Copy link

welcome bot commented Dec 22, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/connecting-to-github-with-ssh/working-with-ssh-key-passphrases.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
 fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

cmwilson21 commented Dec 22, 2022

@victoremeka - Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Dec 22, 2022
@sophietheking sophietheking added the needs SME This proposal needs review from a subject matter expert label Jan 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

dscho
dscho reviewed Feb 8, 2023
View reviewed changes
content/authentication/connecting-to-github-with-ssh/working-with-ssh-key-passphrases.md
## Auto-launching `ssh-agent` on Git for Windows

You can run `ssh-agent` automatically when you open bash or Git shell. Copy the following lines and paste them into your `~/.profile` or `~/.bashrc` file in Git shell:
You can run `ssh-agent` automatically when you open bash or Git shell. Copy the following lines and paste them into the `~/.profile` or `~/.bashrc` file found in your `~/git/etc` folder:
Copy link
Contributor

@dscho dscho Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping "Git shell" from this text only makes sense if you forget about all Windows-based users: Outside of the Git Bash (i.e. in a CMD or a PowerShell), ~/.profile does not make any sense on Windows.

So I would strongly advise against accepting this change as-is.

@victoremeka victoremeka requested a review from dscho February 27, 2023 10:36
@dscho
Copy link
Contributor

dscho commented Feb 28, 2023

@victoremeka my assessment from #22822 (comment) still stands: I strongly advise to revise the patch so that it does not forget about literally all Windows users.

@cmwilson21
Copy link
Contributor

cmwilson21 commented Mar 3, 2023

I'm going to go ahead and close this PR out 💛

If you'd like to adjust the PR per the suggestion above to include Windows users, please do so and submit a new PR.

Thank you for your interest in improving GitHub Docs! 💖

@cmwilson21 cmwilson21 closed this Mar 3, 2023
@cmwilson21 cmwilson21 mentioned this pull request Mar 3, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dscho dscho Awaiting requested review from dscho

Assignees

No one assigned

Labels

authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unclear directions for locating .bashrc or .profile file in Windows

4 participants

@victoremeka @cmwilson21 @dscho @sophietheking