Clarify release event trigger behaviour#5769
Merged
skedwards88 merged 3 commits intogithub:mainfrom Apr 27, 2021
foosel:patch-1
Merged
Clarify release event trigger behaviour#5769skedwards88 merged 3 commits intogithub:mainfrom foosel:patch-1
skedwards88 merged 3 commits intogithub:mainfrom
foosel:patch-1
Conversation
As it turns out, the release event will not trigger with `prereleased` type for pre releases getting published from drafts, only with `published`.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
skedwards88
reviewed
Apr 27, 2021
Contributor
skedwards88
left a comment
There was a problem hiding this comment.
🎉 Thank you for digging into this and for opening a PR to document your findings! I suggested some small wording changes. If this still sounds good to you, I'll get it merged down.
Thanks! Co-authored-by: Sarah Edwards <skedwards88@github.com>
Contributor
Author
|
Sounds good to me, I've committed these suggestions! |
skedwards88
approved these changes
Apr 27, 2021
Contributor
|
Awesome! I'll get this merged down for you. |
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
As it turns out, the release event will not trigger with
prereleasedtype for pre releases getting published from drafts, only withpublished. This adds a little note to clarify this behaviour.Closes #5767
What's being changed:
I've added a small note:
Check off the following:
Writer impact (This section is for GitHub staff members only):