Skip to content

Conversation

@Wladefant
Copy link
Contributor

@Wladefant Wladefant commented Jan 9, 2023

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

More up to date and neater

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@Wladefant Wladefant requested a review from a team as a code owner January 9, 2023 13:54
Copy link
Contributor

@smashwilson smashwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall these changes look pretty good! I'm a fan of the expanded and clarified descriptions.

We do try not to overuse the "related" topics feature... otherwise, virtually every topic could be related to "software", for example, which wouldn't be very useful. We also try to make sure that the topics we list as aliases or related are already being used in the wild (we don't add "speculative" topic associations). In fact, if you find places where we have let empty topics slip in, you could do us a favor by taking them out 😎

One more thing - in general, we prefer to split things up so that each PR touches a single topic (or collection) when possible. It makes it easier to review and your changes get in more quickly, because we could merge the ones for the topic changes you've proposed that we don't have suggested changes for while we're going back and forth on the ones we do. There are exceptions to that but I think it would really help these kinds of maintenance updates!

Thanks so much for all of the effort you're putting in here! I'll be happy to merge this in once we resolve all the suggestion threads.

@Wladefant
Copy link
Contributor Author

Understood ;). Thank you for the help!!! Resolved all conflicts

@kenyonj kenyonj added the awaiting-response Waiting for a response from PR author label Jan 23, 2023
Copy link

@ABoutPapper ABoutPapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Modeling, graphics of the Animation's for all various Industries look great.

Copy link

@gumafia gumafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ทำตามอำเภอใจไปหรือปล่าว แล้วผมจะแก้ไขอะไรได้บ้างเหรอ แต่ก็ดีไม่ต้องแก้อะไรเพราะกูไม่รู้จะทำยังไง แอนดรอย2สายพันธ์

@gumafia
Copy link

gumafia commented Jan 25, 2023

ทำอย่างนี้จะอยู่ในเครื่องเพื่ออะไรพอแสดงความเห็นหน่อยก็ล้มเลิกที่ปรับปรุงเลยเหรอ

Wladefant and others added 2 commits February 3, 2023 10:38
@kenyonj kenyonj removed the awaiting-response Waiting for a response from PR author label Feb 8, 2023
Copy link
Contributor

@kenyonj kenyonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for your contribution!

@kenyonj kenyonj added this pull request to the merge queue Feb 8, 2023
@kenyonj kenyonj removed this pull request from the merge queue due to a manual request Feb 8, 2023
@kenyonj kenyonj enabled auto-merge February 8, 2023 20:33
@kenyonj kenyonj disabled auto-merge February 8, 2023 20:35
@kenyonj kenyonj added this pull request to the merge queue Feb 8, 2023
@kenyonj kenyonj removed this pull request from the merge queue due to a manual request Feb 9, 2023
@kenyonj kenyonj added this pull request to the merge queue Feb 9, 2023
@kenyonj kenyonj removed this pull request from the merge queue due to a manual request Feb 9, 2023
@kenyonj kenyonj added this pull request to the merge queue Feb 9, 2023
@kenyonj kenyonj removed this pull request from the merge queue due to a manual request Feb 10, 2023
@kenyonj kenyonj added this pull request to the merge queue Feb 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2023
@kenyonj kenyonj enabled auto-merge February 10, 2023 16:17
@kenyonj kenyonj added this pull request to the merge queue Feb 10, 2023
Merged via the queue into github:main with commit 5150172 Feb 10, 2023
@Wladefant Wladefant deleted the update-topics branch February 10, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants