-
Notifications
You must be signed in to change notification settings - Fork 13.9k
update-topics #3487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-topics #3487
Conversation
smashwilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall these changes look pretty good! I'm a fan of the expanded and clarified descriptions.
We do try not to overuse the "related" topics feature... otherwise, virtually every topic could be related to "software", for example, which wouldn't be very useful. We also try to make sure that the topics we list as aliases or related are already being used in the wild (we don't add "speculative" topic associations). In fact, if you find places where we have let empty topics slip in, you could do us a favor by taking them out 😎
One more thing - in general, we prefer to split things up so that each PR touches a single topic (or collection) when possible. It makes it easier to review and your changes get in more quickly, because we could merge the ones for the topic changes you've proposed that we don't have suggested changes for while we're going back and forth on the ones we do. There are exceptions to that but I think it would really help these kinds of maintenance updates!
Thanks so much for all of the effort you're putting in here! I'll be happy to merge this in once we resolve all the suggestion threads.
|
Understood ;). Thank you for the help!!! Resolved all conflicts |
f9fc524 to
8db0aa0
Compare
ABoutPapper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Modeling, graphics of the Animation's for all various Industries look great.
gumafia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ทำตามอำเภอใจไปหรือปล่าว แล้วผมจะแก้ไขอะไรได้บ้างเหรอ แต่ก็ดีไม่ต้องแก้อะไรเพราะกูไม่รู้จะทำยังไง แอนดรอย2สายพันธ์
|
ทำอย่างนี้จะอยู่ในเครื่องเพื่ออะไรพอแสดงความเห็นหน่อยก็ล้มเลิกที่ปรับปรุงเลยเหรอ |
Co-authored-by: Ash Wilson <smashwilson@github.com>
kenyonj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for your contribution!
Please confirm this pull request meets the following requirements:
Which change are you proposing?
Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:
*.png, square, dimensions 288x288, size <= 75 kB)index.md)Curating a new topic or collection
https://github.com/topics/[NAME]orhttps://github.com/collections/[NAME])*.pngimage (if applicable) andindex.mdindex.mdconform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docsSomething that does not neatly fit into the binary options above
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.