Skip to content

Conversation

@lacasseio
Copy link

I'm a Gradle engineer simply changing the logo to the new branding. I'm not changing anything else thus I don't see any conflict of interest aside from removing confusion around the brand by avoiding 2 different logos. See the main GitHub organization and website of the project.

Thank you for contributing! Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288)
  • Content (and my changes are in index.md)

Gradle went through an update of their logos and I'm simply updating each one I come across.

Signed-off-by: Daniel Lacasse <daniel@gradle.com>
@lacasseio
Copy link
Author

@kenyonj The CI failures seems to be related to other repositories going offline/removed/became private/etc. Do you know when there will be a chance to look into the changes?

@talsafran
Copy link
Contributor

talsafran commented Jun 13, 2019

@lacasseio thank you for this contribution ✨! I fixed the issues with CI in #800, so this is good to ship too 🚢🍏!

@talsafran talsafran merged commit 45d4118 into github:master Jun 13, 2019
@lacasseio lacasseio deleted the lacasseio/new-gradle-logo branch June 14, 2019 13:00
@lacasseio
Copy link
Author

Hey @talsafran, thanks for merging this PR. Do you know how long does it take for the change to take effect? I'm still seeing the old logo event though it was merged 2 days ago. Thanks for the information.

@richarddd44

This comment has been minimized.

@talsafran
Copy link
Contributor

@lacasseio thanks for the ping 😄. Your update should be live now! https://github.com/topics/gradle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants