Skip to content

[deep-report] Remove zombie validateImportedStepsNoAgenticSecrets no-op validator + fix stale TODO #44333

Description

@github-actions

Description

The repository-quality audit (discussion #44304, 2026-07-08) identified two zombie code items in pkg/workflow that mislead readers at zero functional cost:

  1. validateImportedStepsNoAgenticSecrets (defined imported_steps_validation.go:41, called compiler_orchestrator_engine.go:439) is documented as a no-op since custom engine support was removed, yet it is still invoked with two meaningful params (engineConfig, engineSetting) it discards. Remove the call, the function body, and the log line at 438.
  2. compiler_jobs.go:216 carries a // TODO: Job implementation is pending; buildEvalsJob currently returns nil comment that is factually wrongevals_job.go contains a fully-implemented 106-line buildEvalsJob that returns nil only when HasEvals() is false (correct behaviour). Replace the TODO with accurate documentation.

Expected Impact

Removes ~50 lines of dead code and eliminates a misleading call site + false TODO. Zero functional change.

Suggested Agent

Repository Quality / Code Simplifier agent.

Estimated Effort

Quick (< 1 hour)

Data Source

DeepReport 2026-07-08 · repository-quality report #44304

Generated by 🔬 Deep Report · 301.4 AIC · ⌖ 10.9 AIC · ⊞ 10K ·

  • expires on Jul 10, 2026, 7:37 AM UTC-08:00

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions