Description
The repository-quality audit (discussion #44304, 2026-07-08) identified two zombie code items in pkg/workflow that mislead readers at zero functional cost:
validateImportedStepsNoAgenticSecrets (defined imported_steps_validation.go:41, called compiler_orchestrator_engine.go:439) is documented as a no-op since custom engine support was removed, yet it is still invoked with two meaningful params (engineConfig, engineSetting) it discards. Remove the call, the function body, and the log line at 438.
compiler_jobs.go:216 carries a // TODO: Job implementation is pending; buildEvalsJob currently returns nil comment that is factually wrong — evals_job.go contains a fully-implemented 106-line buildEvalsJob that returns nil only when HasEvals() is false (correct behaviour). Replace the TODO with accurate documentation.
Expected Impact
Removes ~50 lines of dead code and eliminates a misleading call site + false TODO. Zero functional change.
Suggested Agent
Repository Quality / Code Simplifier agent.
Estimated Effort
Quick (< 1 hour)
Data Source
DeepReport 2026-07-08 · repository-quality report #44304
Generated by 🔬 Deep Report · 301.4 AIC · ⌖ 10.9 AIC · ⊞ 10K · ◷
Description
The repository-quality audit (discussion #44304, 2026-07-08) identified two zombie code items in
pkg/workflowthat mislead readers at zero functional cost:validateImportedStepsNoAgenticSecrets(definedimported_steps_validation.go:41, calledcompiler_orchestrator_engine.go:439) is documented as a no-op since custom engine support was removed, yet it is still invoked with two meaningful params (engineConfig,engineSetting) it discards. Remove the call, the function body, and the log line at438.compiler_jobs.go:216carries a// TODO: Job implementation is pending; buildEvalsJob currently returns nilcomment that is factually wrong —evals_job.gocontains a fully-implemented 106-linebuildEvalsJobthat returns nil only whenHasEvals()is false (correct behaviour). Replace the TODO with accurate documentation.Expected Impact
Removes ~50 lines of dead code and eliminates a misleading call site + false TODO. Zero functional change.
Suggested Agent
Repository Quality / Code Simplifier agent.
Estimated Effort
Quick (< 1 hour)
Data Source
DeepReport 2026-07-08 · repository-quality report #44304