Description
The dangerous-permissions compile-time error message links to a documentation path that does not exist in the repository, causing user friction at a security-relevant decision point.
Current State
pkg/workflow/dangerous_permissions_validation.go line 85, in formatDangerousPermissionsError:
lines = append(lines, "which uses a scoped GitHub App token. See: docs/safe-outputs.md")
docs/safe-outputs.md does not exist anywhere in the repo. Every comparable validator uses the canonical published reference URL instead, e.g.:
pkg/workflow/strict_mode_permissions_validation.go:37
pkg/workflow/compiler_main_job_helpers.go:344
pkg/workflow/compiler_activation_permissions.go:246
These all point to https://github.github.com/gh-aw/reference/safe-outputs/.
Suggested Changes
- Replace the dead relative path in
pkg/workflow/dangerous_permissions_validation.go:85 with the canonical published reference URL https://github.github.com/gh-aw/reference/safe-outputs/, matching the pattern used elsewhere in the codebase.
Files Affected
pkg/workflow/dangerous_permissions_validation.go (line 85)
Success Criteria
- Error message references a working, canonical URL consistent with sibling validators
make test-unit passes (add/adjust a test asserting the message text if one exists)
Source
Extracted from User Experience Analysis Report - 2026-08-04 (discussion #50298)
Priority
Low - Small, isolated string fix improving trust/reliability of a security-relevant error message.
🔍 Task mining by Discussion Task Miner - Code Quality Improvement Agent · auto · 39.6 AIC · ⌖ 3.24 AIC · ⊞ 10.3K · ◷
Description
The dangerous-permissions compile-time error message links to a documentation path that does not exist in the repository, causing user friction at a security-relevant decision point.
Current State
pkg/workflow/dangerous_permissions_validation.goline 85, informatDangerousPermissionsError:docs/safe-outputs.mddoes not exist anywhere in the repo. Every comparable validator uses the canonical published reference URL instead, e.g.:pkg/workflow/strict_mode_permissions_validation.go:37pkg/workflow/compiler_main_job_helpers.go:344pkg/workflow/compiler_activation_permissions.go:246These all point to
https://github.github.com/gh-aw/reference/safe-outputs/.Suggested Changes
pkg/workflow/dangerous_permissions_validation.go:85with the canonical published reference URLhttps://github.github.com/gh-aw/reference/safe-outputs/, matching the pattern used elsewhere in the codebase.Files Affected
pkg/workflow/dangerous_permissions_validation.go(line 85)Success Criteria
make test-unitpasses (add/adjust a test asserting the message text if one exists)Source
Extracted from User Experience Analysis Report - 2026-08-04 (discussion #50298)
Priority
Low - Small, isolated string fix improving trust/reliability of a security-relevant error message.