Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/cd374e81-561b-4340-8188-8ad2fd3205fa Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/cd374e81-561b-4340-8188-8ad2fd3205fa Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the Extension Upgrade Test workflow to validate upgrade paths for newly created releases (including prereleases) and to centralize post-matrix conclusion handling with failure escalation.
Changes:
- Add
release: { types: [created] }trigger and broaden release selection to include non-draft prereleases. - Add a
conclusionjob that aggregates matrix job outcomes and writes a compact summary. - Create a GitHub issue on release-triggered failures, with scoped per-job permissions under workflow-level
permissions: {}.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/upgrade-test.yml |
Adds release-created trigger, prerelease-aware release selection, and a conclusion/issue-escalation flow with minimized permissions. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
| on: | ||
| workflow_dispatch: {} | ||
| release: | ||
| types: [created] |
There was a problem hiding this comment.
on: release: types: [created] will also run for draft releases. Since the workflow later assumes the target tag is installable, draft releases are likely to fail/spam issues. Consider switching the trigger to types: [published] (still includes prereleases) or add a job-level guard like if: github.event.release.draft == false for the release path.
| types: [created] | |
| types: [published] |
| EOF | ||
| ) | ||
|
|
||
| gh issue create --title "$TITLE" --body "$BODY" --label "bug" |
There was a problem hiding this comment.
gh issue create is executed in the conclusion job without checking out the repo or specifying a repository, so gh may not know which repo to operate on and can fail. Pass --repo "${{ github.repository }}" (or set GH_REPO) or add a checkout step before creating the issue.
| gh issue create --title "$TITLE" --body "$BODY" --label "bug" | |
| gh issue create --repo "${{ github.repository }}" --title "$TITLE" --body "$BODY" --label "bug" |
🧪 Test Quality Sentinel Report
Workflow-as-Test ObservationsThe changed file (
Language SupportTests analyzed:
Verdict
References:
|
The extension upgrade workflow only validated stable/latest paths and had no centralized post-matrix conclusion handling for release runs. This update adds release-created coverage (including prereleases), aggregates matrix outcomes, and opens a failure issue when release validation fails.
Trigger + scope
release: { types: [created] }to run upgrade validation on newly created releases.workflow_dispatchand PR-path trigger for iterative development.Release selection logic (includes prereleases)
/releases/latestbehavior with release-list selection that includes non-draft prereleases.github.event.release.tag_nameas the upgrade target and select the next most recent non-draft release asn-1.Conclusion job with failure escalation
conclusionjob (if: always()) to collect per-OS matrix outcomes from the run.Permission minimization
permissions: {}).contents: readactions: read,contents: read,issues: write