[instructions] Sync instruction files with release v0.85.0 - #50526
[instructions] Sync instruction files with release v0.85.0#50526github-actions[bot] wants to merge 1 commit into
Conversation
- designer.md had regrown to 416 lines after the maintainer.md repository-survey guidance (added in #50413/#50422) was duplicated into a new Phase 1b section that fully restated maintainer.md's survey table. Replaced it with a pointer to maintainer.md, and collapsed the file's redundant dual in-repo/portable-URL reference lists into one list with a prefix-substitution note (416 -> 394 lines). - Added maintainer.md to the compact reference table in github-agentic-workflows.md and to update-agentic-workflow.md's topic file list; it was reachable only from designer.md/create-agentic-workflow.md. - Added the Crush shared engine (#50430) to configure-agentic-engine.md's example list, alongside the already-documented OpenCode/Goose/Aider/Cursor/Kiro. - Generalized syntax-engine.md's opencode-only shared-engine callout into one line covering all shared CLI engines (opencode, goose, aider, cursor, kiro, crush), pointing at configure-agentic-engine.md instead of hardcoding one example that goes stale as engines are added. - Documented the `report-failed-jobs` safe-outputs global flag (pkg/workflow/safe_outputs_config_types.go), added in #49959 and previously undocumented, next to the related report-failure-as-issue field in safe-outputs-runtime.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
🎯 Thanks for keeping the instruction documentation in sync with v0.85.0! Your audit-driven approach looks solid:
The PR is well-scoped to documentation, the changes are substantive and well-reasoned, and the audit confirms accuracy across the engine and safe-outputs config spaces. This looks ready for review! 🚀
|
|
@copilot Please take another pass on this PR.
|
|
@copilot Please take another pass on this PR.
|
Summary
Ran the instructions-janitor Release/Change, Size, Duplication, and Accuracy audits (baseline: last sync commit
97b00a63, covering 90 commits through80b45ff3, release v0.85.0).Files changed
.github/aw/designer.md— 416 → 394 lines.github/aw/github-agentic-workflows.md— 160 → 161 lines.github/aw/update-agentic-workflow.md— 121 → 122 lines.github/aw/configure-agentic-engine.md— 177 → 177 lines.github/aw/syntax-engine.md— 87 → 87 lines.github/aw/safe-outputs-runtime.md— 298 → 300 linesWhat changed and why
designer.mdregrew past the 400-line target (416 lines) after a new "Phase 1b: Repository Survey" section was added that fully re-stated the survey signal list already owned by the newmaintainer.md(added in Add repository maintainer sample prompt #50413/Favor shared workflow engine configuration #50422 for recurring repository-maintenance workflows). Replaced the restated section with a short pointer tomaintainer.md, and collapsed designer.md's redundant dual "In-repo references" / "Portable HTTPS references" lists (which mirrored each other 1:1) into a single list plus a one-line prefix-substitution note — no other.github/aw/*.mdfile uses that dual-list pattern. Net: 416 → 394 lines, duplication removed.maintainer.md(208 lines, new) was only linked fromdesigner.mdandcreate-agentic-workflow.md. Added it togithub-agentic-workflows.md's compact reference table andupdate-agentic-workflow.md's topic-file list so it's reachable the same waycampaign.md/experiments.mdare.configure-agentic-engine.md's shared-engine example list named OpenCode/Goose/Aider/Cursor/Kiro but not Crush (.github/workflows/shared/crush.md, added in Implementing shared agentic workflow with charmbracelet/crush #50430) — added it.syntax-engine.mdonly called outopencodeas an importable shared engine; generalized that line to cover all shared CLI engines and point atconfigure-agentic-engine.mdinstead of hardcoding one example (reduces future staleness as engines are added/removed — antigravity's removal in Removing support for the antigravity agentic engine #50460 was already reflected correctly).SafeOutputsConfig(pkg/workflow/safe_outputs_config_types.go) against the safe-outputs docs; foundreport-failed-jobs(added in feat: report failed non-builtin jobs as issues from conclusion job #49959, controls whether failed customjobs:are reported as issues from the conclusion job) had no documentation anywhere. Added it next to the relatedreport-failure-as-issue/failure-issue-repofields insafe-outputs-runtime.md.Documentation commits reviewed
git log/compare-API pass over97b00a63...80b45ff3(90 commits), with focused diff review of: #50413/#50422 (maintainer.md + designer.md/create-agentic-workflow.md survey integration), #50278/#50244/#50234 (agentfinder removal from skills.md), #50460 (antigravity engine removal), #50430 (Crush shared engine), #49959 (report-failed-jobs), plus the configure-agentic-engine.md rewrite toward shared-markdown engine definitions.Audits performed
97b00a63(2026-08-04) to HEAD80b45ff3via the GitHub compare API (90 commits). Identified 8 touched.github/aw/*.mdfiles plusactions-lock.json(routine digest bump, no action needed).wc -l .github/aw/*.md— onlydesigner.mdexceeded 400 lines (416); fixed to 394. All other files, including the newly addedmaintainer.md(208), are within target..github/aw/*.md).syntax-engine.md,safe-outputs*.md,syntax*.md/create-agentic-workflow.md, andconfigure-agentic-engine.mdagainstpkg/workflow/agentic_engine.go,pkg/workflow/safe_outputs_config_types.go,pkg/parser/schemas/main_workflow_schema.json, andpkg/workflow/data/engines/. Confirmed the recent antigravity-removal and shared-engine-definition rewrites are accurate; found and fixed the one real gap (report-failed-jobs) plus the Crush/opencode-only engine-list gaps above.Confirmation
.github/aw/*.mdfile is under its target limit (largest: designer.md at 394/400 lines)Run: https://github.com/github/gh-aw/actions/runs/30998678554