Merged
Conversation
ipmsteven
reviewed
Apr 21, 2020
kytrinyx
force-pushed
the
kytrinyx/bump-rubocop-v0.78.0
branch
from
1aab862 to
7cbdc80
Compare
kytrinyx
changed the base branch from
kytrinyx/update-rubies
to
kytrinyx/gem-dependencies
joelhawksley
approved these changes
Apr 21, 2020
kytrinyx
force-pushed
the
kytrinyx/gem-dependencies
branch
from
c83f9bb to
0498224
Compare
This is a breaking change. To get this to pass CI, I have done the following: * deleted performance cops * renamed a Metrics/LineLength to Layout/LineLength * deleted another Metrics/LineLength The performance cops appear to have been extracted into a separate gem, https://github.com/rubocop-hq/rubocop-performance and as of 0.78.0 referencing them without including the rubocop-performance gem as a dependency blows up.
kytrinyx
force-pushed
the
kytrinyx/bump-rubocop-v0.78.0
branch
from
7cbdc80 to
7bdf804
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #59
This is a breaking change.To get this to pass CI, I have done the following:
deleted performance copsThe performance cops appear to have been extracted into a separate gem,https://github.com/rubocop-hq/rubocop-performance and as of 0.78.0
referencing them without including the rubocop-performance gem as a
dependency blows up.
Update: I updated the gemspec to include the rubocop-performance and rubocop-rails gems in #63