Bump js-yaml from ^4.2.0 to ^5.0.0#4451
Merged
Merged
Conversation
js-yaml v5 is rewritten in TypeScript and ships its own type declarations, so @types/js-yaml is no longer needed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the extensions/ql-vscode extension to use js-yaml v5 (which now ships its own TypeScript declarations), and adjusts qlpack YAML loading to preserve the existing “empty/whitespace file => empty object” semantics without invoking the YAML parser on blank input.
Changes:
- Bump
js-yamldependency from^4.2.0to^5.0.0. - Remove
@types/js-yamlfrom devDependencies (now provided byjs-yamlitself). - Avoid calling
js-yaml.loadfor whitespace-only qlpack files, while still normalizing empty/undefined parses to{}before schema validation.
Show a summary per file
| File | Description |
|---|---|
| extensions/ql-vscode/src/packaging/qlpack-file-loader.ts | Skips YAML parsing for blank/whitespace files and continues to normalize empty content to {} before AJV validation. |
| extensions/ql-vscode/package.json | Updates js-yaml to v5 and removes @types/js-yaml. |
| extensions/ql-vscode/package-lock.json | Locks js-yaml to v5.x and removes @types/js-yaml from the resolved dependency tree. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Files not reviewed (1)
- extensions/ql-vscode/package-lock.json: Generated file
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Low
Contributor
Author
|
I took one of the fixes from #4438, which seems to be enough to get CI checks to pass. |
Contributor
|
LGTM. Sorry for dropping the ball on #4438 . |
josefs
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
js-yaml v5 is rewritten in TypeScript and ships its own type declarations, so @types/js-yaml is no longer needed.