Bump @octokit/plugin-throttling, plus fixes - #4485
Merged
Merged
Conversation
Bumps [@octokit/plugin-throttling](https://github.com/octokit/plugin-throttling.js) from 9.6.0 to 11.0.3. - [Release notes](https://github.com/octokit/plugin-throttling.js/releases) - [Commits](octokit/plugin-throttling.js@v9.6.0...v11.0.3) --- updated-dependencies: - dependency-name: "@octokit/plugin-throttling" dependency-version: 11.0.3 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
An Octokit upgrade made retryCount a required property of OctokitResponse, breaking check-types on test mocks. Add retryCount: 0 to the affected RequestError response mocks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6e6540a4-5a88-4ac5-96c9-ddb6af5996fc
nickrolfe
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Octokit throttling to v11 and aligns test mocks with updated response types.
Changes:
- Bumps
@octokit/plugin-throttlingto 11.0.3. - Refreshes transitive Octokit dependencies.
- Adds required
retryCountfields to mocked responses.
Show a summary per file
| File | Description |
|---|---|
extensions/ql-vscode/package.json |
Updates the throttling dependency. |
extensions/ql-vscode/package-lock.json |
Locks compatible Octokit dependencies. |
extensions/ql-vscode/test/vscode-tests/no-workspace/databases/github-databases/api.test.ts |
Updates mocked error responses. |
extensions/ql-vscode/test/vscode-tests/activated-extension/variant-analysis/variant-analysis-monitor.test.ts |
Updates a mocked error response. |
extensions/ql-vscode/test/unit-tests/variant-analysis/custom-errors.test.ts |
Updates the shared error fixture. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Files not reviewed (1)
- extensions/ql-vscode/package-lock.json: Generated file
- Files reviewed: 4/5 changed files
- Comments generated: 0
- Review effort level: Medium
josefs
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4463 plus some Copilot-generated fixes to make
npm run check-typespass.