[workspacekit] Fix empty JSON deserialization error#13192
Merged
Conversation
[workspacekit] Fix empty JSON deserialization error
sagor999
approved these changes
Sep 21, 2022
utam0k
approved these changes
Sep 21, 2022
roboquat
added
deployed: workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If
GITPOD_RLIMIT_COREenv variable it's empty we should not attempt to deserialize an empty stringRelated Issue(s)
Fixes https://cloudlogging.app.goo.gl/QYQWPUhwnjeTQiXD7
How to test
cannot deserialize GITPOD_RLIMIT_COREerrors.Release Notes
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide