Skip to content

[workspacekit] Fix empty JSON deserialization error #13192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roboquat merged 1 commit into from
Sep 21, 2022
Merged

[workspacekit] Fix empty JSON deserialization error #13192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions components/workspacekit/cmd/rings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,11 +834,14 @@ var ring2Cmd = &cobra.Command{
Max uint64 `json:"hardLimit"`
}

rLimitValue := os.Getenv("GITPOD_RLIMIT_CORE")
var rLimitCore fakeRlimit
err = json.Unmarshal([]byte(rLimitValue), &rLimitCore)
if err != nil {
log.WithError(err).WithField("data", rLimitValue).Error("cannot deserialize GITPOD_RLIMIT_CORE")

rLimitValue := os.Getenv("GITPOD_RLIMIT_CORE")
if len(rLimitValue) != 0 {
err = json.Unmarshal([]byte(rLimitValue), &rLimitCore)
if err != nil {
log.WithError(err).WithField("data", rLimitValue).Error("cannot deserialize GITPOD_RLIMIT_CORE")
}
}

// we either set a limit or explicitly disable core dumps by setting 0 as values
Expand Down