Updated appDisplay types - #124
Merged
Merged
Conversation
JumpLink
approved these changes
Jun 29, 2026
JumpLink
left a comment
JumpLink
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed against gnome-shell 50.0. This all checks out:
- All class
@seeline references line up withjs/ui/appDisplay.js. - The signal definitions match the upstream
Signalsblocks with the right param types:view-loaded(BaseAppView),apps-changed(FolderIcon),open-state-changed/menu-state-changed/sync-tooltiptyped with thebooleanpayload. - The removed methods are genuinely gone in 50.0:
shellWorkspaceLaunch,cancelActions,_removeMenuTimeout,_setPopupTimeout,updateDragFocus, and the publiconDragBegin/updateRunningStyle(the latter is now the private_updateRunningStyle). - The getter/signature changes all match:
get id/get nameonAppViewItem(withappcorrectly moved toAppIconasShell.App),getDragActorSource(): St.Icon(return this.icon.icon),popupMenu()withoutside(now thepopupMenuSidector prop),createFolder(apps: string[]).
Nicely done. Two minor, non-blocking nits:
PageManagerdefines alayout-changedsignal that is consumed internally (appDisplay.js:1324) but isn't reflected in its typings, soconnect('layout-changed', …)falls back to the generic GObject overload. SincePageManageris a non-exporteddeclare class, this is just a precision nit.- Re your note on
_onScrollusingClutter.ScrollEvent: that's a@girsgeneration quirk (the union variant carries the type info), not something to fix in this PR.
Approving.
This was referenced Jun 29, 2026
Rayzeq
pushed a commit
to Rayzeq/gnome-shell
that referenced
this pull request
Jul 22, 2026
PageManager defines a 'layout-changed' signal (appDisplay.js:1254)
that is connected internally (appDisplay.js:1324), but the typings
omitted it, so connect('layout-changed', ...) fell back to the
generic GObject.Object overload.
Add a SignalSignatures namespace plus typed connect/connect_after
overloads, mirroring the pattern used for the other classes in this
file. PageManager stays module-local (not exported), so the namespace
is local as well.
Follow-up to gjsify#124.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a lot with a lot of similar looking classes and functions that have slightly different types. I checked it again but it is possible that I mixed something up.
Also the
_onScrollmethod is usingClutter.ScrollEventwhich is technically correct but it does not really have any type info. Only its union variantClutter.Eventhas. It is probably a generation bug or something.((also in the original js file, the line at https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/ui/appDisplay.js#L641 is unused, just a leftover that did not get cleaned up. In case someone wants to notify or submit a PR to Gnome Shell))