Type PageManager's layout-changed signal - #134
Merged
Merged
Conversation
PageManager defines a 'layout-changed' signal (appDisplay.js:1254)
that is connected internally (appDisplay.js:1324), but the typings
omitted it, so connect('layout-changed', ...) fell back to the
generic GObject.Object overload.
Add a SignalSignatures namespace plus typed connect/connect_after
overloads, mirroring the pattern used for the other classes in this
file. PageManager stays module-local (not exported), so the namespace
is local as well.
Follow-up to #124.
This was referenced Jun 29, 2026
Totto16
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #124, addressing the typing nit I flagged during review.
PageManagerdefines alayout-changedsignal (appDisplay.js#L1254) that is connected internally (appDisplay.js#L1324), but its typings omitted it — soconnect('layout-changed', …)fell back to the genericGObject.Objectoverload instead of a typed one.This adds a
SignalSignaturesnamespace plus typedconnect/connect_afteroverloads, mirroring the pattern already used forBaseAppView,FolderIcon,AppIconandAppFolderDialogin the same file. SincePageManageris a non-exporteddeclare class, the namespace is kept module-local as well (TypeScript requires the merged declarations to be consistently exported or local).The other nit from the review —
_onScrolltyped withClutter.ScrollEvent— is a@girsgeneration quirk (only theClutter.Eventunion variant carries the field types), so it's out of scope here.Validated locally with the full CI sequence (
build:types,prettier:check,validate:types,build:example,validate:example) — all green.